cwtch.im
/
ui
Archived
6
7
Fork 2
Code Issues 64 Pull Requests 2 Releases 9 Wiki Activity

Alert the user when there is no internet (first cut) #233

Manually merged
dan merged 1 commits from network_check into master 2019-11-12 20:15:52 +00:00
Conversation 5 Commits 1 Files Changed 4 +64 -4
sarah commented 2019-11-06 19:12:49 +00:00
Owner
Copy Link

There are still some open questions here which I'd like to revisit later like : should we restart the listen server of all peers, but this gives us the infrastructure to build such features

There are still some open questions here which I'd like to revisit later like : should we restart the listen server of all peers, but this gives us the infrastructure to build such features
dan was assigned by sarah 2019-11-06 19:12:49 +00:00
buildbot commented 2019-11-06 19:16:21 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/417

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/417
dan requested changes 2019-11-06 20:15:49 +00:00
go/characters/appEventListener.go Outdated
@ -45,3 +61,3 @@
}
gcd.TorStatus(statuscode, message)
if !networkOffline {
dan commented 2019-11-06 20:14:06 +00:00
Owner

I'm not sure network status updates from a cwtch plugin should supercede updates from the ACN, epsecially when those will be about it turning back on, and therefor forever prevented from appearing

networkOffline happens, is set to true, ACN tries to restart and sends updates, they are discarded in the UI until its alrady online and waits till the cwtch plugin can connect and sets networkOffline to false and then updates the UI straight from 0 to on

I'm not sure network status updates from a cwtch plugin should supercede updates from the ACN, epsecially when those will be about it turning back on, and therefor forever prevented from appearing networkOffline happens, is set to true, ACN tries to restart and sends updates, they are discarded in the UI until its alrady online and waits till the cwtch plugin can connect and sets networkOffline to false and then updates the UI straight from 0 to on
dan commented 2019-11-06 20:14:07 +00:00
Owner

I'm not sure network status updates from a cwtch plugin should supercede updates from the ACN, epsecially when those will be about it turning back on, and therefor forever prevented from appearing

networkOffline happens, is set to true, ACN tries to restart and sends updates, they are discarded in the UI until its alrady online and waits till the cwtch plugin can connect and sets networkOffline to false and then updates the UI straight from 0 to on

I'm not sure network status updates from a cwtch plugin should supercede updates from the ACN, epsecially when those will be about it turning back on, and therefor forever prevented from appearing networkOffline happens, is set to true, ACN tries to restart and sends updates, they are discarded in the UI until its alrady online and waits till the cwtch plugin can connect and sets networkOffline to false and then updates the UI straight from 0 to on
go/characters/incominglistener.go Outdated
@ -32,0 +36,4 @@
case event.NetworkStatus:
the.AppBus.Publish(*e)
if e.Data["Status"] == "Success" && networkOffline {
dan commented 2019-11-06 20:15:46 +00:00
Owner

I don't think we need to handle anything here, we can always add it in when we determine we need to

I don't think we need to handle anything here, we can always add it in when we determine we need to
buildbot commented 2019-11-06 20:52:57 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/421

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/421
buildbot commented 2019-11-06 21:15:04 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/423

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/423
sarah commented 2019-11-12 18:53:34 +00:00
Author
Owner
Copy Link

Most of the work here happened in Cwtch and go-ricochet PRs - Tor better handles restarts, we minimized potential race conditions (there are still a few around eventbus we need to deal with in Cwtch, and current connections don't detect timeouts - this is something we should handle in Tapir)

But for now, this PR restarts Tor when the interet goes down and the peer now recovers

Most of the work here happened in Cwtch and go-ricochet PRs - Tor better handles restarts, we minimized potential race conditions (there are still a few around eventbus we need to deal with in Cwtch, and current connections don't detect timeouts - this is something we should handle in Tapir) But for now, this PR restarts Tor when the interet goes down and the peer now recovers
buildbot commented 2019-11-12 18:55:30 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/427

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/427
dan closed this pull request 2019-11-12 20:15:52 +00:00
dan closed this pull request 2019-11-12 20:15:52 +00:00
dan deleted branch network_check 2019-11-12 20:16:01 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/ui#233
No description provided.
Delete Branch "network_check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?