assets folder + emoji drawer #254

erinn · 2020-01-08T22:49:51Z

erinn commented

2020-01-08 22:49:51 +00:00

Assets folder is extremely simple; just write paths in QML as gcd.assetPath + "path/to/file.png". Per our discussion, our existing release bundling workflow shouldn't need to be changed. The makefile temporarily moves the assets folder from root into the appropriate build folder before building, and qtdeploy takes care of it from there.

I had to manually merge the Makefile and fear I may have munged it a bit so please pay extra attention to it.

The emoji drawer is a bit of a rough cut but it would be nice to dogfood it a bit before our next release.

Assets folder is extremely simple; just write paths in QML as `gcd.assetPath + "path/to/file.png"`. Per our discussion, our existing release bundling workflow shouldn't need to be changed. The makefile temporarily moves the `assets` folder from root into the appropriate build folder before building, and qtdeploy takes care of it from there. I had to manually merge the Makefile and fear I may have munged it a bit so please pay extra attention to it. The emoji drawer is a bit of a rough cut but it would be nice to dogfood it a bit before our next release.

dan was assigned by erinn

2020-01-08 22:49:51 +00:00

buildbot commented

2020-01-08 22:52:53 +00:00

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/461

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/461

buildbot commented

2020-01-08 23:00:26 +00:00

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/463

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/463

dan commented

2020-01-08 23:52:54 +00:00

main.go

gcd.SetAssetPath(path.Join(dir, "assets") + "/")

the '+ "/"' is not os agnostic, won't play well on windows, and just out side the os safe path.Join --- from further checking bewlow and seeing its only used in qml/js, i'm optimistically willing to hope this might actually work?

qml/main.qml

T.twemoji.base = gcd.assetPath + "twemoji/"

prolly need at least gcd.assetPath + "/twemoji/" but i'm concerned about windows compatibility. In my dreams QML does the slash/path transform for us correctly cus JS + web magic... but I'll need to test

qml/eidgets/EmojiDrawers.qml

 ToolTip.text: qsTr("Click to toggle category\n"+(gcd.os == "android" ? "Long-press" : "Right-click")+" to reset")

this will cause translation problems, we need two different string ids (like clock-toggle-andoid and click-toggle-dekstop) to be picked from. Then just run lupdate ui.proto update the human translateable files,linquistand load the .en one and enter the translations (and mark them done/aproved) and then runlrelease ui.pro` to update the translation files

x the above comment for each time in this file this is done

**main.go** ``` gcd.SetAssetPath(path.Join(dir, "assets") + "/") ``` the '+ "/"' is not os agnostic, won't play well on windows, and just out side the os safe path.Join --- from further checking bewlow and seeing its only used in qml/js, i'm optimistically willing to hope this might actually work? **qml/main.qml** ``` T.twemoji.base = gcd.assetPath + "twemoji/" ``` prolly need at least `gcd.assetPath + "/twemoji/"` but i'm concerned about windows compatibility. In my dreams QML does the slash/path transform for us correctly cus JS + web magic... but I'll need to test **qml/eidgets/EmojiDrawers.qml** ``` ToolTip.text: qsTr("Click to toggle category\n"+(gcd.os == "android" ? "Long-press" : "Right-click")+" to reset") ``` this will cause translation problems, we need two different string ids (like `clock-toggle-andoid and click-toggle-dekstop) to be picked from. Then just run `lupdate ui.pro` to update the human translateable files, `linquist` and load the .en one and enter the translations (and mark them done/aproved) and then run `lrelease ui.pro` to update the translation files x the above comment for each time in this file this is done

dan commented

2020-01-09 00:01:37 +00:00

qrc.qml was deleted - should be restored

erinn referenced this issue from a commit

2020-01-10 20:41:02 +00:00

addressing dan comments in #254

buildbot commented

2020-01-10 20:44:06 +00:00

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/465

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/465

erinn referenced this issue from a commit