#272 Using new cwtch attributes and get/ret val requests

Merged
sarah merged 2 commits from dan/ui:keyval into master 1 month ago
dan commented 2 months ago
There is no content yet.

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/508

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/508

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/509

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/509
dan changed title from WIP: Using new cwtch attributes and get/ret val requests to Using new cwtch attributes and get/ret val requests 2 months ago

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/510

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/510
sarah requested changes 2 months ago
go/handlers/peerHandler.go
@@ -93,0 +99,4 @@
}
}
case event.NewRetValMessageFromPeer:
// TODO: update the ui
sarah

?

?
dan

oph, reminder to myself i didnt delete after I filled the case:

oph, reminder to myself i didnt delete after I filled the case:
go/ui/gcd.go
@@ -331,0 +327,4 @@
if !exists {
zoom = "1.0"
}
locale, exists := the.Peer.GetAttribute(attr.GetSettingsScope(constants.LocaleSetting))
sarah

I feel we need a better way of managing defaults than this.

I feel we need a better way of managing defaults than this.
dan

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this
go/ui/imageType.go
@@ -0,0 +3,4 @@
import "encoding/json"

const (
TypeImageDistro = "distro"
sarah

wat? needs documentation

wat? needs documentation
go/ui/manager.go
@@ -57,0 +69,4 @@
log.Infof("get nick for contact %v\n", id)
nick, exists := the.Peer.GetContactAttribute(id, attr.GetLocalScope(constants.Name))
if !exists {
log.Infof("local !exits\n")
sarah

remove infos

remove infos
go/ui/manager.go
@@ -57,0 +72,4 @@
log.Infof("local !exits\n")
nick, exists = the.Peer.GetContactAttribute(id, attr.GetPeerScope(constants.Name))
if !exists {
log.Infof("peer !exists\n")
sarah

and this one

and this one
go/ui/manager.go
@@ -85,3 +103,1 @@
return RandomGroupImage(id)
} else {
return profilePicRelativize(pic)
log.Debugln("is group")
sarah

remove overly verbose debug statements like this one

remove overly verbose debug statements like this one
go/ui/manager.go
@@ -97,1 +135,4 @@

func getPicturePath(pic *image) string {
log.Debugf("getPicturePath for %v\n", pic)
if pic.T == TypeImageDistro {
sarah

should be a switch statement with a default

should be a switch statement with a default

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/511

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/511

Reviewers

sarah requested changes 2 months ago
The pull request has been merged as 632136f193.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.