cwtch.im
/
ui
Arquivado
6
7
Fork 2

Using new cwtch attributes and get/ret val requests #272

Merge aplicado
sarah aplicou merge dos 1 commits de :keyval em master 2020-03-31 19:06:38 +00:00
Proprietário
Nenhuma descrição fornecida.
Membro

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/508

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/508
Membro

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/509

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/509
dan alterou o título de WIP: Using new cwtch attributes and get/ret val requests para Using new cwtch attributes and get/ret val requests 2020-03-30 16:17:59 +00:00
Membro

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/510

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/510
sarah alterações solicitadas 2020-03-30 18:37:04 +00:00
@ -93,0 +99,4 @@
}
}
case event.NewRetValMessageFromPeer:
// TODO: update the ui
Proprietário

?

?
Autor
Proprietário

oph, reminder to myself i didnt delete after I filled the case:

oph, reminder to myself i didnt delete after I filled the case:
go/ui/gcd.go Desatualizado
@ -331,0 +327,4 @@
if !exists {
zoom = "1.0"
}
locale, exists := the.Peer.GetAttribute(attr.GetSettingsScope(constants.LocaleSetting))
Proprietário

I feel we need a better way of managing defaults than this.

I feel we need a better way of managing defaults than this.
Autor
Proprietário

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this
go/ui/imageType.go Desatualizado
@ -0,0 +3,4 @@
import "encoding/json"
const (
TypeImageDistro = "distro"
Proprietário

wat? needs documentation

wat? needs documentation
go/ui/manager.go Desatualizado
@ -57,0 +69,4 @@
log.Infof("get nick for contact %v\n", id)
nick, exists := the.Peer.GetContactAttribute(id, attr.GetLocalScope(constants.Name))
if !exists {
log.Infof("local !exits\n")
Proprietário

remove infos

remove infos
go/ui/manager.go Desatualizado
@ -57,0 +72,4 @@
log.Infof("local !exits\n")
nick, exists = the.Peer.GetContactAttribute(id, attr.GetPeerScope(constants.Name))
if !exists {
log.Infof("peer !exists\n")
Proprietário

and this one

and this one
go/ui/manager.go Desatualizado
@ -85,3 +103,1 @@
return RandomGroupImage(id)
} else {
return profilePicRelativize(pic)
log.Debugln("is group")
Proprietário

remove overly verbose debug statements like this one

remove overly verbose debug statements like this one
go/ui/manager.go Desatualizado
@ -97,1 +135,4 @@
func getPicturePath(pic *image) string {
log.Debugf("getPicturePath for %v\n", pic)
if pic.T == TypeImageDistro {
Proprietário

should be a switch statement with a default

should be a switch statement with a default
Membro

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/511

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/511
sarah fechou este pull request 2020-03-31 19:06:38 +00:00
Este repositório está arquivado. Você não pode comentar nos pull requests.
Nenhuma descrição fornecida.