Using new cwtch attributes and get/ret val requests #272

dan 于 2020-03-30 16:17:59 +00:00 修改标题 ~~WIP: Using new cwtch attributes and get/ret val requests~~ 为 Using new cwtch attributes and get/ret val requests

buildbot 评论于

2020-03-30 16:22:53 +00:00

普通成员

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/510

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/510

sarah 请求变更 2020-03-30 18:37:04 +00:00

go/handlers/peerHandler.go 已过期

					
				@ -93,0 +99,4 @@

								}

							}

						case event.NewRetValMessageFromPeer:

							// TODO: update the ui

sarah 评论于

2020-03-30 18:15:38 +00:00

管理员

?

dan 评论于

2020-03-30 20:57:27 +00:00

作者

管理员

oph, reminder to myself i didnt delete after I filled the case:

go/ui/gcd.go 已过期

					
				@ -331,0 +327,4 @@

					if !exists {

						zoom = "1.0"

					}

					locale, exists := the.Peer.GetAttribute(attr.GetSettingsScope(constants.LocaleSetting))

sarah 评论于

2020-03-30 18:34:18 +00:00

管理员

I feel we need a better way of managing defaults than this.

dan 评论于

2020-03-30 21:00:24 +00:00

作者

管理员

we were doing nothing. open to suggestions. we don't really have a good handle yet on what our settings will ultimatly be, we need to work on our settings management some. Erinn has some ideas on this

go/ui/imageType.go 已过期

					
				@ -0,0 +3,4 @@

				import "encoding/json"

				const (

					TypeImageDistro      = "distro"

sarah 评论于

2020-03-30 18:34:53 +00:00

管理员

wat? needs documentation

go/ui/manager.go 已过期

					
				@ -57,0 +69,4 @@

						log.Infof("get nick for contact %v\n", id)

						nick, exists := the.Peer.GetContactAttribute(id, attr.GetLocalScope(constants.Name))

						if !exists {

							log.Infof("local !exits\n")

sarah 评论于

2020-03-30 18:35:26 +00:00

管理员

remove infos

go/ui/manager.go 已过期

					
				@ -57,0 +72,4 @@

							log.Infof("local !exits\n")

							nick, exists = the.Peer.GetContactAttribute(id, attr.GetPeerScope(constants.Name))

							if !exists {

								log.Infof("peer !exists\n")

sarah 评论于

2020-03-30 18:35:36 +00:00

管理员

and this one

go/ui/manager.go 已过期

					
				@ -85,3 +103,1 @@

							return RandomGroupImage(id)

						} else {

							return profilePicRelativize(pic)

						log.Debugln("is group")

sarah 评论于

2020-03-30 18:36:02 +00:00

管理员

remove overly verbose debug statements like this one

go/ui/manager.go 已过期

					
				@ -97,1 +135,4 @@

				func getPicturePath(pic *image) string {

					log.Debugf("getPicturePath for %v\n", pic)

					if pic.T == TypeImageDistro {