Redesign: contact Row and Picture: themeing and modularizing: #276

dan · 2020-04-08T17:39:23Z

dan commented

2020-04-08 17:39:23 +00:00

Redesign: contact Row and Picture: themeing and modularizing:

Picture was split into Badge, and Portrait
ContactRow was split into: PortraitRow, ProfileRow, and ContactRow
Removed some unsued cruft
Still need to work on adopting new images (requires coloring b/w images
to theme colors...) And adding the new accept/reject new contact
workflow

Redesign: contact Row and Picture: themeing and modularizing: - Picture was split into Badge, and Portrait - ContactRow was split into: PortraitRow, ProfileRow, and ContactRow - Removed some unsued cruft - Still need to work on adopting new images (requires coloring b/w images to theme colors...) And adding the new accept/reject new contact workflow

erinn was assigned by dan

2020-04-08 17:39:23 +00:00

buildbot commented

2020-04-08 17:42:07 +00:00

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/523

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/523

erinn commented

2020-04-15 22:28:15 +00:00

badge dimensions aren't dynamic anymore... long numbers eg 999 will overflow out of the badge circle
if (status == 4 || status == 3) ... else if (status == 3 || status == 2) is redundant
some things in the attached screenshot:
- long profile names and onion strings cross the scrollbar
- the profile images in the message pane seem to be of varying sizes for some reason?
- profile images in the message pane have an empty white badge
in general, not necessarily for this PR: this diff was somewhat hard to review because our indentation is getting messier over time... can we get a formatting tool involved? would either https://github.com/jesperhh/qmlfmt or https://github.com/Orange-OpenSource/qmljsreformatter work with our process? both annoyingly appear to replace tabs with spaces but i'm willing to trade one pain for the other in this case lol

* badge dimensions aren't dynamic anymore... long numbers eg 999 will overflow out of the badge circle * if (status == 4 || status == **3**) ... else if (status == **3** || status == 2) is redundant * some things in the attached screenshot: * long profile names and onion strings cross the scrollbar * the profile images in the message pane seem to be of varying sizes for some reason? * profile images in the message pane have an empty white badge * in general, not necessarily for this PR: this diff was somewhat hard to review because our indentation is getting messier over time... can we get a formatting tool involved? would either https://github.com/jesperhh/qmlfmt or https://github.com/Orange-OpenSource/qmljsreformatter work with our process? both annoyingly appear to replace tabs with spaces but i'm willing to trade one pain for the other in this case lol

Screenshot_20200415_151544.png

284 KiB

dan commented

2020-04-15 23:34:59 +00:00

awesome, I'll dig into this

responses

badge dimensions aren't dynamic anymore... long numbers eg 999 will overflow out of the badge circle

asking marcia
if so: textMetric code to be put back in... but width is decoupled, the filler content is in contactRow and badge width initially set in Badge... so that'll be something for me to figure out

if (status == 4 || status == 3) ... else if (status == 3 || status == 2) is redundant

fixed
-_-;

some things in the attached screenshot:

long profile names and onion strings cross the scrollbar
- existing behaviour but more noticable now with larger fonts
  TODO
  - resize min width of bar to at least fit onion address
  - use ?textMetric to ellipsise text before spilling off
the profile images in the message pane seem to be of varying sizes for some reason?
- thats down to how they are being invoked by the message pane. I was thinking that out of scope for this PR, as this is def a WIP and I was thinking to sort that out when I did a full message pane treatment. should have called it out, is ok?
profile images in the message pane have an empty white badge
- ditto
in general, not necessarily for this PR: this diff was somewhat hard to review because our indentation is getting messier over time... can we get a formatting tool involved? would either https://github.com/jesperhh/qmlfmt or https://github.com/Orange-OpenSource/qmljsreformatter work with our process? both annoyingly appear to replace tabs with spaces but i'm willing to trade one pain for the other in this case lol
- I can take a look and prep a seperate PR where I run one of them over the code + a tidy.sh script to keep it going, gooooood call out!

awesome, I'll dig into this responses - badge dimensions aren't dynamic anymore... long numbers eg 999 will overflow out of the badge circle asking marcia if so: textMetric code to be put back in... but width is decoupled, the filler content is in contactRow and badge width initially set in Badge... so that'll be something for me to figure out - [x] if (status == 4 || status == 3) ... else if (status == 3 || status == 2) is redundant fixed -_-; some things in the attached screenshot: - long profile names and onion strings cross the scrollbar - existing behaviour but more noticable now with larger fonts TODO - [ ] resize min width of bar to at least fit onion address - [ ] use ?textMetric to ellipsise text before spilling off - the profile images in the message pane seem to be of varying sizes for some reason? - thats down to how they are being invoked by the message pane. I was thinking that out of scope for this PR, as this is def a WIP and I was thinking to sort that out when I did a full message pane treatment. should have called it out, is ok? - [ ] profile images in the message pane have an empty white badge - ditto - in general, not necessarily for this PR: this diff was somewhat hard to review because our indentation is getting messier over time... can we get a formatting tool involved? would either https://github.com/jesperhh/qmlfmt or https://github.com/Orange-OpenSource/qmljsreformatter work with our process? both annoyingly appear to replace tabs with spaces but i'm willing to trade one pain for the other in this case lol - I can take a look and prep a seperate PR where I run one of them over the code + a tidy.sh script to keep it going, gooooood call out!

dan commented

2020-04-16 22:26:25 +00:00

if (status == 4 || status == 3) ... else if (status == 3 || status == 2) is redundant

fixed

long profile names and onion strings cross the scrollbar

now elipsis dynamically

badge dimensions aren't dynamic anymore... long numbers eg 999 will overflow out of the badge circle

badge dimensions stay fixed but as per marcia, number caps at string "99+" which fits

the profile images in the message pane seem to be of varying sizes for some reason?
profile images in the message pane have an empty white badge

To be addressed in message pane PR

in general, not necessarily for this PR: this diff was somewhat hard to review because our indentation is getting messier over time... can we get a formatting tool involved? would either https://github.com/jesperhh/qmlfmt or https://github.com/Orange-OpenSource/qmljsreformatter work with our process? both annoyingly appear to replace tabs with spaces but i'm willing to trade one pain for the other in this case lol

scheduling for seperate PR cus... all the red/green as all the whitespace changes

> if (status == 4 || status == 3) ... else if (status == 3 || status == 2) is redundant fixed > long profile names and onion strings cross the scrollbar now elipsis dynamically > badge dimensions aren't dynamic anymore... long numbers eg 999 will overflow out of the badge circle badge dimensions stay fixed but as per marcia, number caps at string "99+" which fits > the profile images in the message pane seem to be of varying sizes for some reason? > profile images in the message pane have an empty white badge To be addressed in message pane PR > in general, not necessarily for this PR: this diff was somewhat hard to review because our indentation is getting messier over time... can we get a formatting tool involved? would either https://github.com/jesperhh/qmlfmt or https://github.com/Orange-OpenSource/qmljsreformatter work with our process? both annoyingly appear to replace tabs with spaces but i'm willing to trade one pain for the other in this case lol scheduling for seperate PR cus... all the red/green as all the whitespace changes

buildbot commented

2020-04-16 22:27:11 +00:00

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/524

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/524

dan commented

2020-04-16 22:27:24 +00:00

No description provided.

cwtch portrait row.png

26 KiB