Android Deep Dive Part 1 of Many #378

Merged
erinn merged 2 commits from android_tests into master 2020-11-20 23:24:39 +00:00
Owner
  1. Convert image to webp
  2. New ANDROID_DEBUGGIN.md file
  3. Layout improvements
1. Convert image to webp 2. New ANDROID_DEBUGGIN.md file 3. Layout improvements
sarah added the
android
label 2020-11-17 21:22:37 +00:00
dan was assigned by sarah 2020-11-17 21:22:37 +00:00
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/774

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/774
Owner
  • ui/settings.go change the default zoom back to 1.0 and in ReadGlobalSettings on line 62ish change the android specific zoom
  • add a Opaque.Flickable to SettingsPane.qml
    -main.go - why is android using the same port and not the random tor controlport ports?
  • settingsPane.qml
    • width should not be parent-20 but 700*gcd.themeScale
    • we might want an Opaque function or tool for wrappers, that are columns around 700 on mobile and on gcd.os == "android" it's width is based on parent width
    • supplySettings is now a NOP with a return
- ui/settings.go change the default zoom back to 1.0 and in ReadGlobalSettings on line 62ish change the android specific zoom - add a Opaque.Flickable to SettingsPane.qml -main.go - why is android using the same port and not the random tor controlport ports? - settingsPane.qml - ~~width should not be parent-20 but 700*gcd.themeScale~~ - we might want an Opaque function or tool for wrappers, that are columns around 700 on mobile and on gcd.os == "android" it's width is based on parent width - supplySettings is now a NOP with a return
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/779

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/779
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/780

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/780
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/781

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/781
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/786

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/786
Owner
  • in settings.go you have the new default zoom changed from 1.0 to 1.9 (which will be for desktop)
  • you have some cool new sig handling code that does a lot of stack dumping, do we want that always on, or maybe only active when the -debug flag is on?
  • any reason not to do random tor ports on android?
  • for settingsPane we probably want a MaxWidth? as per mocks, on desktop its not parent width forever, it caps out, at somewhere around 700*gcd.themeScale
  • serverRow has a //badgeVisible = true comment that can probably be deleted
  • MessageEditor: restoreEmoji and replacements of newlines were deleted, is that functionality renabled somewhere else?
- in settings.go you have the new default zoom changed from 1.0 to 1.9 (which will be for desktop) - you have some cool new sig handling code that does a lot of stack dumping, do we want that always on, or maybe only active when the -debug flag is on? - any reason not to do random tor ports on android? - for settingsPane we probably want a MaxWidth? as per mocks, on desktop its not parent width forever, it caps out, at somewhere around 700*gcd.themeScale - serverRow has a `//badgeVisible = true` comment that can probably be deleted - MessageEditor: restoreEmoji and replacements of newlines were deleted, is that functionality renabled somewhere else?
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/789

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/789
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/791

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/791
sarah changed title from WIP: Android Deep Dive Part 1 of Many to Android Deep Dive Part 1 of Many 2020-11-20 23:13:01 +00:00
Member

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/793

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/793
Author
Owner

Resolution on settings pane moved to: #384 since it's a much bigger issue than just how it looks compared to mocks.

Resolution on settings pane moved to: https://git.openprivacy.ca/cwtch.im/ui/issues/384 since it's a much bigger issue than just how it looks compared to mocks.
erinn merged commit a54aa8e0af into master 2020-11-20 23:24:39 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.