cwtch.im
/
ui
Archived
6
7
Fork 2
Code Issues 64 Pull Requests 2 Releases 9 Wiki Activity

nsis script to make windows installer #432

Merged
erinn merged 3 commits from nsi into master 2020-11-28 01:55:31 +00:00
Conversation 3 Commits 3 Files Changed 4 +91
dan commented 2020-11-28 00:07:05 +00:00
Owner
Copy Link
No description provided.
buildbot commented 2020-11-28 00:10:09 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/864

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/864
erinn requested changes 2020-11-28 01:06:51 +00:00
nsis/cwtch-installer.nsi Outdated
@ -0,0 +9,4 @@
Unicode True
# define the name of the installer
Outfile "cwtch-installer.exe"
erinn commented 2020-11-28 00:56:51 +00:00
Owner

can we get this on build.openprivacy.ca?

can we get this on build.openprivacy.ca?
dan commented 2020-11-28 01:25:38 +00:00
Author
Owner

yup that's the plan. Once merged I can add a nsis docker image to the server and work on configuring a drone stage to generate it and upload it :)

yup that's the plan. Once merged I can add a nsis docker image to the server and work on configuring a drone stage to generate it and upload it :)
erinn marked this conversation as resolved
nsis/cwtch-installer.nsi Outdated
@ -0,0 +20,4 @@
InstallDir "$PROGRAMFILES\Cwtch"
;Get installation folder from registry if available
InstallDirRegKey HKCU "Software\Cwtch" ""
erinn commented 2020-11-28 00:58:49 +00:00
Owner

does MUI generate an uninstaller? can users remove cwtch via the windows add/remove programs panel after installing it?

does MUI generate an uninstaller? can users remove cwtch via the windows add/remove programs panel after installing it?
dan commented 2020-11-28 01:27:03 +00:00
Author
Owner

nsis can. this config doesn't do that. that's gonna be another project. Ideally a day, but you saw how well this one went... so.. #TODO?

nsis can. this config doesn't do that. that's gonna be another project. Ideally a day, but you saw how well this one went... so.. #TODO?
erinn marked this conversation as resolved
nsis/cwtch-installer.nsi Outdated
@ -0,0 +48,4 @@
; Pages --------
!define MUI_WELCOMEPAGE_TITLE "Welcome to the Cwtch installer"
erinn commented 2020-11-28 00:55:09 +00:00
Owner

we'll have to figure out how to translate these...

we'll have to figure out how to translate these...
dan commented 2020-11-28 01:27:48 +00:00
Author
Owner

NSIS has languages and you can I believe tag things with languages... but yeah. that'll be ... a later project as well

NSIS has languages and you can I believe tag things with languages... but yeah. that'll be ... a later project as well
erinn marked this conversation as resolved
nsis/cwtch-installer.nsi Outdated
@ -0,0 +53,4 @@
Cwtch is a platform for building consentful, decentralized, untrusted infrastructure using metadata resistant group communication applications. Currently there is a selfnamed instant messaging prototype app that is driving development and testing. Many Further apps are planned as the platform matures."
!define MUI_FINISHPAGE_TITLE "Enjoy Cwtch"
!define MUI_FINISHPAGE_RUN $INSTDIR/ui.exe
erinn commented 2020-11-28 01:03:24 +00:00
Owner

quotes?

quotes?
dan commented 2020-11-28 01:28:07 +00:00
Author
Owner

apparently don't need them

apparently don't need them
erinn marked this conversation as resolved
nsis/cwtch-installer.nsi Outdated
@ -0,0 +54,4 @@
!define MUI_FINISHPAGE_TITLE "Enjoy Cwtch"
!define MUI_FINISHPAGE_RUN $INSTDIR/ui.exe
!define MUI_FINISHPAGE_TEXT "You can keep uptodate on Cwtch and report any issues you have at https://cwtch.im"
erinn commented 2020-11-28 00:43:09 +00:00
Owner

nit: up-to-date

nit: up-to-date
dan commented 2020-11-28 01:29:10 +00:00
Author
Owner

fixed

fixed
nsis/cwtch-installer.nsi Outdated
@ -0,0 +56,4 @@
!define MUI_FINISHPAGE_RUN $INSTDIR/ui.exe
!define MUI_FINISHPAGE_TEXT "You can keep uptodate on Cwtch and report any issues you have at https://cwtch.im"
!define MUI_FINISHPAGE_LINK "https://cwtch.im"
!define MUI_FINISHPAGE_LINK_LOCATION "https://cwtch.im"
erinn commented 2020-11-28 01:01:39 +00:00
Owner

the app itself avoids making clickable links... do we want to apply that policy to the installer as well?

the app itself avoids making clickable links... do we want to apply that policy to the installer as well?
nsis/cwtch-installer.nsi Outdated
@ -0,0 +73,4 @@
Section
# define the output path for this file
SetOutPath $INSTDIR
erinn commented 2020-11-28 01:04:19 +00:00
Owner

quotes?

quotes?
dan commented 2020-11-28 01:29:22 +00:00
Author
Owner

doesn't need them

doesn't need them
erinn marked this conversation as resolved
nsis/cwtch-installer.nsi Outdated
@ -0,0 +83,4 @@
# create a shortcut named "new shortcut" in the start menu programs directory
# presently, the new shortcut doesn't call anything (the second field is blank)
erinn commented 2020-11-28 01:00:08 +00:00
Owner

outdated comment?

outdated comment?
dan commented 2020-11-28 01:30:14 +00:00
Author
Owner

fixed

fixed
nsis/cwtch-installer.nsi Outdated
@ -0,0 +87,4 @@
CreateShortcut "$SMPROGRAMS\Cwtch.lnk" "$INSTDIR\ui.exe"
;Store installation folder
WriteRegStr HKCU "Software\Cwtch" "" $INSTDIR
erinn commented 2020-11-28 01:05:29 +00:00
Owner

does $INSTDIR potentially need quotes? this ref to ui.exe has quotes but there's one above that does not

does $INSTDIR potentially need quotes? this ref to ui.exe has quotes but there's one above that does not
dan commented 2020-11-28 01:32:56 +00:00
Author
Owner

doesn't need it, its in my registry fine

doesn't need it, its in my registry fine
erinn marked this conversation as resolved
buildbot commented 2020-11-28 01:39:40 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/866

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/866
erinn approved these changes 2020-11-28 01:55:23 +00:00
erinn merged commit d4e5546079 into master 2020-11-28 01:55:31 +00:00
buildbot commented 2020-11-28 01:58:19 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/868

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/868
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
erinn
Labels
Clear labels   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/ui#432
No description provided.
Delete Branch "nsi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?