cwtch.im
/
ui
Archived
6
7
Fork 2
Code Issues 64 Pull Requests 2 Releases 9 Wiki Activity

Save state of root and profile panes open, and selected profile and conversation; jump to those when reloading #443

Merged
erinn merged 2 commits from :stateful into master 2020-12-07 23:24:35 +00:00
Conversation 4 Commits 2 Files Changed 10 +155 -32
dan commented 2020-12-05 01:43:03 +00:00
Owner
Copy Link
No description provided.
buildbot commented 2020-12-05 01:46:14 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/903

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/903
sarah reviewed 2020-12-05 01:47:43 +00:00
main.go Outdated
@ -86,3 +87,3 @@
if *flagDebug {
log.SetLevel(log.LevelDebug)
} else {
} else if *flagInfo {
sarah commented 2020-12-05 01:47:33 +00:00
Owner

Doesn't this violate standard convention? I would assume:

Fatal - Always Crashes
Error - Always Show - action required
Warn - Always Show - automatic recovery
Info - Default
Debug - 1-level Debug
Trace - 2-level Debug

Doesn't this violate standard convention? I would assume: Fatal - Always Crashes Error - Always Show - action required Warn - Always Show - automatic recovery Info - Default Debug - 1-level Debug Trace - 2-level Debug
dan commented 2020-12-05 06:05:04 +00:00
Author
Owner

reverted

reverted
dan commented 2020-12-05 06:05:28 +00:00
Author
Owner

and changed two other things to debug :)

and changed two other things to debug :)
main.go Outdated
@ -95,3 +95,2 @@
}
log.ExcludeFromPattern("connection/connection")
//log.ExcludeFromPattern("outbound/3dhauthchannel")
log.ExcludeFromPattern("outbound/3dhauthchannel")
sarah commented 2020-12-05 01:44:49 +00:00
Owner

I'm 99% sure this doesn't even exist anymore

I'm 99% sure this doesn't even exist anymore
dan commented 2020-12-05 06:05:14 +00:00
Author
Owner

removed

removed
buildbot commented 2020-12-05 06:07:31 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/904

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/904
erinn requested changes 2020-12-07 22:46:13 +00:00
go/ui/gcd.go Outdated
@ -791,0 +825,4 @@
selectedPane, pok := the.Peer.GetAttribute(attr.GetSettingsScope(constants.StateProfilePane))
if pok {
selectedPaneId, ok := strconv.Atoi(selectedPane)
if ok == nil {
erinn commented 2020-12-07 22:43:18 +00:00
Owner

nit: ok -> err

nit: ok -> err
go/ui/gcd.go Outdated
@ -791,0 +836,4 @@
this.TimelineInterface.handle = selectedContact
this.loadMessagesPane(selectedContact)
if len(selectedContact) == 56 { // peer
erinn commented 2020-12-07 22:46:01 +00:00
Owner

nit: !Utils.isGroup(selectedContact)

nit: !Utils.isGroup(selectedContact)
buildbot commented 2020-12-07 23:22:56 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/905

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/905
erinn merged commit e5fce8634e into master 2020-12-07 23:24:34 +00:00
buildbot commented 2020-12-07 23:29:29 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/906

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/906
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
erinn
Labels
Clear labels   
1app

   
2 apps

   
accessibility

   
android

   
before-beta

issues that need to be fixed before beta

  
bug

   
duplicate

   
enhancement

   
first-contact

   
fixed

   
help wanted

   
infrastructure

   
invalid

   
low-priority

   
must-fix

   
needs testing

issues that are presumed fixed but need testing

  
nice-to-have

   
question

   
tor

   
user-feedback

   
wontfix
No Label
1app
2 apps
accessibility
android
before-beta
bug
duplicate
enhancement
first-contact
fixed
help wanted
infrastructure
invalid
low-priority
must-fix
needs testing
nice-to-have
question
tor
user-feedback
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/ui#443
No description provided.
Delete Branch ":stateful"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?