new scaling system pass one #457

Open
erinn wants to merge 4 commits from newzoom into master
erinn commented 9 months ago

needs opaque merged first

needs opaque merged first

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/951

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/951
dan requested changes 9 months ago
dan left a comment

I'll need to download and test the MyProfile changes. I thought the reason I had a function there was QML basically said doing anything complex with just properties is undefiend so for changes like we want there do it with an ugly function

font.pixelSize: 18 * gcd.themeScale
text: qsTr("peer-not-online")
}
// Label {
dan commented 9 months ago

This shouldn't be commented out

This shouldn't be commented out
erinn marked this conversation as resolved
Opaque.Setting {
property color backgroundColor: parent.color
property color backgroundColor: "red"//parent.color
dan commented 9 months ago

undebug :)

undebug :)
erinn marked this conversation as resolved
ChatOverlay { //0
Layout.maximumHeight: overlayStack.height
Layout.maximumWidth: overlayStack.width
// Layout.maximumHeight: overlayStack.height
dan commented 9 months ago

if we don't need them then we should delete?

if we don't need them then we should delete?
erinn marked this conversation as resolved
Opaque.Button { // ADD or SAVE button
height: Theme.primaryTextSize * 1.5
//height: Theme.primaryTextSize * 1.5
dan commented 9 months ago

switch to new textSize?

switch to new textSize?
erinn commented 9 months ago

it calculates its own height

it calculates its own height
erinn marked this conversation as resolved
RowLayout {
width: 700 * gcd.themeScale
//width: 700 * gcd.themeScale
dan commented 9 months ago

I think this did need a min size of some kind?

I think this did need a min size of some kind?
erinn commented 9 months ago

maybe an android thing?

maybe an android thing?
erinn marked this conversation as resolved
//Layout.fillWidth: true
Layout.maximumWidth: 450 * gcd.themeScale
Layout.minimumWidth: 450 * gcd.themeScale
//Layout.maximumWidth: 450 * gcd.themeScale
dan commented 9 months ago

delete?

delete?
erinn marked this conversation as resolved
serverAddEditPane.server_available = !serverAddEditPane.server_available
checked: serverAddEditPane.server_available
onCheckedChanged: function() {
//serverAddEditPane.server_available = !serverAddEditPane.server_available
dan commented 9 months ago

uncomment

uncomment
erinn marked this conversation as resolved
serverAddEditPane.autostart_server = !serverAddEditPane.autostart_server
checked: serverAddEditPane.autostart_server
onCheckedChanged: function() {
//serverAddEditPane.autostart_server = !serverAddEditPane.autostart_server
dan commented 9 months ago

uncomment

uncomment
erinn marked this conversation as resolved
// TODO: Actually do something with these keys
console.log("FOUND SERVER KEY " + key_names[i] + " " + keys[i]);
}
// console.log("Servers: " + key_names);
dan commented 9 months ago

delete :)

delete :)
erinn marked this conversation as resolved
value: gcd.themeScale
live: false
from: 0
to: 4
dan commented 9 months ago

if there's only 3 vals? with a step size of 1, should it' be 0 to 2 inclusive?

if there's only 3 vals? with a step size of 1, should it' be 0 to 2 inclusive?
erinn commented 9 months ago

from Theme.qml:

// magnification system: all size-sets should generally respect these semantics:
//
// scale
// 0 1 2 3 4
// padding S M M M L
// text S S M L L
//
// use the syntax "propertyName: propertyNameBase[p[scale]]" for padding that
// has S/M/L granularity (and likewise t[scale] for text)
// use the syntax "propertyName: propertyNameBase[scale]" for things that you
// would prefer have 0/1/2/3/4 granularity.

from Theme.qml: > // magnification system: all size-sets should generally respect these semantics: > // > // scale > // 0 1 2 3 4 > // padding S M M M L > // text S S M L L > // > // use the syntax "propertyName: propertyNameBase[p[scale]]" for padding that > // has S/M/L granularity (and likewise t[scale] for text) > // use the syntax "propertyName: propertyNameBase[scale]" for things that you > // would prefer have 0/1/2/3/4 granularity.
erinn marked this conversation as resolved
experiment_id: "tapir-groups-experiment"
}
Opaque.Collapser {
dan commented 9 months ago

shouldn't this be outside experiments?

shouldn't this be outside experiments?
erinn commented 9 months ago

that would be lovely but ToggleFields can't go in Collapsers for some reason currently lmao

that would be lovely but ToggleFields can't go in Collapsers for some reason currently lmao
erinn marked this conversation as resolved
}
Opaque.Label {
text: "dependencies, licenses?\nprofile icon pics\nfontawesome? other icon sources?\nmutant standard\nadobe blank\nopensans?"
dan commented 9 months ago

possible lokalise too?

possible lokalise too?
erinn commented 9 months ago

absolutely. and split up by bullet point so we can add/remove individual entries easily. soon!

absolutely. and split up by bullet point so we can add/remove individual entries easily. soon!
erinn marked this conversation as resolved
iconColor: Theme.altTextColor
anchors.verticalCenter: parent.verticalCenter
//anchors.verticalCenter: parent.verticalCenter
dan commented 9 months ago

delete?

delete?
erinn marked this conversation as resolved
onResetServerList: function() {
serversModel.clear()
}
// onResetServerList: function() {
dan commented 9 months ago

uncomment?

uncomment?
erinn commented 9 months ago

never gets called

never gets called
erinn marked this conversation as resolved
erinn referenced this issue from a commit 9 months ago

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/961

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/961

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/ui/963

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/ui/963
erinn changed title from wip: new scaling system pass one to new scaling system pass one 9 months ago

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/ui/965

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/ui/965

looks like all my comments are addressed. I would like to check it out and try it before final approval

looks like all my comments are addressed. I would like to check it out and try it before final approval

Left is newzoom, right is master

  • 1: open a profile
  • 2: open a chat when its wide enough for dual pane mode
  • 3: 'back' to close the chat
  • 4: i think open a chat, widen it more, close, open

some obscure part of QML docs warned that trying to do dynamic position changes with properties only was out of scope and unsupported hence I started using functions. you may want to restore and adapt the function, as hideous as it is, I had here

Left is newzoom, right is master - 1: open a profile - 2: open a chat when its wide enough for dual pane mode - 3: 'back' to close the chat - 4: i think open a chat, widen it more, close, open some obscure part of QML docs warned that trying to do dynamic position changes with properties only was out of scope and unsupported hence I started using functions. you may want to restore and adapt the function, as hideous as it is, I had here
  • way too much padding between MyProfile and the search bar on contactList
  • since the text magnification reference is in a collapser, do we want it in the zoom level area?
  • it's a nit but I think the profile name and onion are padded too far from the profile icon?
  • password entry field I think needs to be longer
  • the icons in the toolbar on top dont seem to be scaling quite along with the toolbar's overall size, so at higher magnifications they appear to be small icons floating in space
- way too much padding between MyProfile and the search bar on contactList - since the text magnification reference is in a collapser, do we want it in the zoom level area? - it's a nit but I think the profile name and onion are padded too far from the profile icon? - password entry field I think needs to be longer - the icons in the toolbar on top dont seem to be scaling quite along with the toolbar's overall size, so at higher magnifications they appear to be small icons floating in space
  • Makefile has -docker for linux
- Makefile has -docker for linux
This repo is archived. You cannot comment on pull requests.
Loading…
There is no content yet.