Dan Ballard dan
  • Joined on 2018-02-25
dan suggested changes for cwtch.im/cwtch#558 2024-05-12 18:12:16 +00:00
Managed Groups First Cut

Ok I've read

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:16 +00:00
Managed Groups First Cut

for now since these are just managed groups with one manager replacing the key is fine because we are assuming an ordered message stream?

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:16 +00:00
Managed Groups First Cut

so this is the managed group check that says this peerMessage is from the groupManager peer so we trust it? if the future with hybrid groups we could get group messages from the group of members with some ACL saying trusted to relay?

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:16 +00:00
Managed Groups First Cut

the AddMemberEvent doesn't come with ACL? maybe i have to read more but how do non default ACL's propagate?

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:16 +00:00
Managed Groups First Cut

why listening to ProtocolEngineCreated?

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:16 +00:00
Managed Groups First Cut

i'm a little fuzzy, would the group manager never be running on a cwtchpeer representing a person with p2p contacts and managed groups? it'll be a stand alone cwtchpeer managing a single group? (cus my next question is what if the profile is in multiple managed groups?)

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:16 +00:00
Managed Groups First Cut

EventsToRegister is ProtocolEngineCreated and NewMessageFromPeerEngine

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

it's not currently wired in anywhere except tests? where's it envisioned to be called from, ah some of the other handle events not yet handled?

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

make it a const for now then :)

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

it feels like some where we need a check this groupmanager hasn't already set up its one fixed name group and throw an error when being called again

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

(and thus an onion service per group) => (and thus a cwtch peer / onion service per group)

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

👍

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

do we want json aliases for these too?

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

ah see this is what i mean, does this mean the way the experiment is compose right now it cannot be scoped to one cwtch peer? only an entire app? that's prolly a hint something in our design is a little off, and it will cause problems for clients cus our libcwtch api is bound to one app

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

we shouldn't need a seperate app, just two peers right? i'd actually be a little more comfortable running both of them out of the same app to make sure they cohabit nicely and peers are properly isolated etc

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

is this not implicit? we don't want ppl setting up peers to have to disable all new and future experiments

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

is this test passing? i'm surprised since we do acn creation after capturing numGoRoutinesStart and defer it's close till this function ends?

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

this isn't "wrapping" it in any way we can currently expose in the API, it's had to be manually done client side, which, isn't wrapping it then.

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:15 +00:00
Managed Groups First Cut

shouldn't this be cut from the test it came from and reused there as well?

dan commented on pull request cwtch.im/cwtch#558 2024-05-12 18:12:14 +00:00
Managed Groups First Cut

How is this exposed API wise? we have a composed CwtchPeer interface already, I would have throught we'd be composing a groupManager cwtch peer to inject these wrappers?