Add Contact for Peer #27

sarah · 2021-03-24T23:36:59Z

sarah commented

2021-03-24 23:36:59 +00:00

No description provided.

dan was assigned by sarah

2021-03-24 23:36:59 +00:00

erinn was assigned by sarah

2021-03-24 23:36:59 +00:00

sarah changed title from ~~WIP: Add Contact for Peer~~ to Add Contact for Peer

2021-03-25 20:28:07 +00:00

erinn approved these changes 2021-03-25 23:40:56 +00:00

lib/views/addcontactview.dart

					
				@ -30,0 +57,4 @@

				  void _copyOnion() {

				    Clipboard.setData(new ClipboardData(text: Provider.of<ProfileInfoState>(context, listen: false).onion));

				    // TODO Toast

erinn commented

2021-03-25 23:39:01 +00:00

you might be able to do:

final snackBar = SnackBar(content: Text(AppLocalizations.of(context).whatever));
ScaffoldMessenger.of(context).showSnackBar(snackBar);

you might be able to do: ``` final snackBar = SnackBar(content: Text(AppLocalizations.of(context).whatever)); ScaffoldMessenger.of(context).showSnackBar(snackBar); ```

dan reviewed 2021-03-26 00:15:24 +00:00

lib/errorHandler.dart

					
				@ -0,0 +1,48 @@

				import 'package:flutter/cupertino.dart';

				class ErrorHandler extends ChangeNotifier {

dan commented

2021-03-26 00:15:24 +00:00

just echoing the symantics comment from my libcwtch-go review, maybe ResponseHandler?

dan approved these changes 2021-03-26 00:16:02 +00:00

dan left a comment

comments aside, lgtm

erinn referenced this issue from a commit

2021-03-29 22:45:16 +00:00

Merge pull request 'Add Contact for Peer' (#27) from peersettings into trunk Reviewed-on: https://git.openprivacy.ca/flutter/flutter_app/pulls/27 Reviewed-by: erinn <erinn@openprivacy.ca> Reviewed-by: Dan Ballard <dan@openprivacy.ca>

erinn merged commit 99fe2a55ab into trunk

2021-03-29 22:45:16 +00:00

sarah referenced this pull request

2021-05-11 23:18:51 +00:00

Erinn Triage #81

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/flutter_app#27