flutter
/
libcwtch-go
5
0
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

Launch Peers on NewPeer + Set Name #16

Merged
dan merged 3 commits from peersettings into trunk 2021-03-19 21:52:37 +00:00
Conversation 0 Commits 3 Files Changed 5 +52 -35
sarah commented 2021-03-19 19:43:04 +00:00
Owner
Copy Link

Also upgrade to 0.6.0

Also upgrade to 0.6.0
dan was assigned by sarah 2021-03-19 19:43:04 +00:00
dan requested changes 2021-03-19 20:01:16 +00:00
utils/eventHandler.go Outdated
@ -107,3 +109,3 @@
cpicPath := GetPicturePath(cpic)
contactInfo := profile.GetContact(contact)
name, _ := contactInfo.GetAttribute(attr.GetLocalScope(constants.Name))
name, hasName := contactInfo.GetAttribute(attr.GetLocalScope(constants.Name))
dan commented 2021-03-19 20:01:03 +00:00
Owner
Copy Link

outside the loop
ph := NewPeerHelper(profile)

then here replace all this with
ph.GetNick(contact)

and actually above should use
ph.GetProfilePic(contact)

you might actaully want to look at if it's possible to adapt EnrichNewPeer() which does this to a PeerCreated event for new contacts of the profile

outside the loop ph := NewPeerHelper(profile) then here replace all this with ph.GetNick(contact) and actually above should use ph.GetProfilePic(contact) you might actaully want to look at if it's possible to adapt EnrichNewPeer() which does this to a PeerCreated event for new contacts of the profile
dan merged commit a741aea975 into trunk 2021-03-19 21:52:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/libcwtch-go#16
No description provided.
Delete Branch "peersettings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?