flutter
/
libcwtch-go
5
0
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

add sendinvitation #38

Merged
sarah merged 3 commits from sendinvite into trunk 2021-05-11 22:37:54 +00:00
Conversation 2 Commits 3 Files Changed 1 +45
erinn commented 2021-05-11 04:34:40 +00:00
Owner
Copy Link
No description provided.
sarah was assigned by erinn 2021-05-11 04:34:40 +00:00
buildbot commented 2021-05-11 04:36:48 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/libcwtch-go/155

Drone Build Status: success https://build.openprivacy.ca/flutter/libcwtch-go/155
sarah reviewed 2021-05-11 17:21:11 +00:00
lib.go
@ -519,0 +545,4 @@
}
inviteBytes, err := json.Marshal(invite)
if err != nil {
sarah commented 2021-05-11 17:21:11 +00:00
Owner
Copy Link

why not use SendMessage here to avoid duplicating code?

why not use SendMessage here to avoid duplicating code?
erinn marked this conversation as resolved
sarah reviewed 2021-05-11 17:21:26 +00:00
lib.go Outdated
@ -41,6 +41,11 @@ var acnQueue event.Queue
var contactEventsQueue event.Queue
var globalACN connectivity.ACN
type ChatMessage struct {
sarah commented 2021-05-11 17:21:26 +00:00
Owner
Copy Link

should have comment or be unexported

should have comment or be unexported
sarah reviewed 2021-05-11 17:21:38 +00:00
lib.go
@ -519,0 +529,4 @@
SendInvitation(profile, handle, target)
}
func SendInvitation(profileOnion, handle, target string) {
sarah commented 2021-05-11 17:21:38 +00:00
Owner
Copy Link

comment functionality

comment functionality
erinn marked this conversation as resolved
erinn referenced this issue from a commit 2021-05-11 22:36:08 +00:00
addressing comments on #38
sarah merged commit bef54c6091 into trunk 2021-05-11 22:37:53 +00:00
buildbot commented 2021-05-11 22:38:09 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/libcwtch-go/158

Drone Build Status: success https://build.openprivacy.ca/flutter/libcwtch-go/158
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
sarah
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/libcwtch-go#38
No description provided.
Delete Branch "sendinvite"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?