flutter
/
libcwtch-go
5
0
Fork 0
Code Issues Pull Requests Releases 2 Wiki Activity

WIP: Build ios #39

Closed
ineiti wants to merge 3 commits from (deleted):ios_build into trunk
pull from: (deleted):ios_build
merge into: flutter:trunk
Conversation 9 Commits 3 Files Changed 5 +44 -6
ineiti commented 2021-05-11 18:06:51 +00:00
First-time contributor
Copy Link

This is a draft PR for the inclusion of iOS in the build system.

It is used by flutter/flutter_app#74

The replacement of sed -i with perl -pi -e is due to the different version of sed on MacOSX, which doesn't include the -i for in-place changes.

This is a draft PR for the inclusion of iOS in the build system. It is used by flutter/flutter_app#74 The replacement of `sed -i` with `perl -pi -e` is due to the different version of `sed` on MacOSX, which doesn't include the `-i` for in-place changes.
buildbot commented 2021-05-11 18:09:30 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/libcwtch-go/156

Drone Build Status: success https://build.openprivacy.ca/flutter/libcwtch-go/156
buildbot commented 2021-05-11 18:10:46 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/libcwtch-go/157

Drone Build Status: success https://build.openprivacy.ca/flutter/libcwtch-go/157
dan was assigned by sarah 2021-05-11 18:21:52 +00:00
sarah changed title from Build ios to WIP: Build ios 2021-05-11 22:44:22 +00:00
dan reviewed 2021-05-11 23:41:19 +00:00
switch-ffi.sh
@ -3,4 +3,1 @@
sed -i "s/^package cwtch/\/\/package cwtch/" lib.go
sed -i "s/^\/\/package main/package main/" lib.go
sed -i "s/^\/\/func main()/func main()/" lib.go
dan commented 2021-05-11 23:41:19 +00:00
Owner
Copy Link

nice, should be good!
but if you're doing this, should change switch-gomobile.sh to match :)

nice, should be good! but if you're doing this, should change switch-gomobile.sh to match :)
ineiti marked this conversation as resolved
buildbot commented 2021-05-14 07:01:58 +00:00
Owner
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/flutter/libcwtch-go/160

Drone Build Status: success https://build.openprivacy.ca/flutter/libcwtch-go/160
ineiti commented 2021-05-14 07:04:37 +00:00
Author
First-time contributor
Copy Link

So I thought that the latest go-version has a correct build-script that takes care of the SDK=iphonesimulator setting. Well, it doesn't...

So I thought that the latest go-version has a correct build-script that takes care of the `SDK=iphonesimulator` setting. Well, it doesn't...
buildbot commented 2021-05-14 07:05:52 +00:00
Owner
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/flutter/libcwtch-go/161

Drone Build Status: failure https://build.openprivacy.ca/flutter/libcwtch-go/161
dan commented 2021-06-15 17:18:40 +00:00
Owner
Copy Link

hey sorry I haven't had time to get to this, I really want to, but we're still plunging head long towards beta release. I'm hoping after that shakes out I'll have some time to dedicate to going over this, getting it merged, and generally helping this along. I think we have another person interested so we might be able to put together an ios/macos group :)

hey sorry I haven't had time to get to this, I really want to, but we're still plunging head long towards beta release. I'm hoping after that shakes out I'll have some time to dedicate to going over this, getting it merged, and generally helping this along. I think we have another person interested so we might be able to put together an ios/macos group :)
sarah commented 2021-06-24 23:32:24 +00:00
Owner
Copy Link

A note to myself to port these changes over to the new repo https://git.openprivacy.ca/cwtch.im/libcwtch-go once beta launch is done.

A note to myself to port these changes over to the new repo https://git.openprivacy.ca/cwtch.im/libcwtch-go once beta launch is done.
dan commented 2021-08-06 21:39:43 +00:00
Owner
Copy Link

moved to new repo!

cwtch.im/libcwtch-go#16

moved to new repo! https://git.openprivacy.ca/cwtch.im/libcwtch-go/pulls/16
dan commented 2021-08-25 16:00:53 +00:00
Owner
Copy Link

closing as the code is now merged into cwtch.im/libcwtch-go and this repo is dead

closing as the code is now merged into cwtch.im/libcwtch-go and this repo is dead
dan closed this pull request 2021-08-25 16:00:53 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/libcwtch-go#39
No description provided.
Delete Branch "(deleted):ios_build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?