add mutex on StartCwtch and ReconnectCwtchForeground #54

Merged
sarah merged 2 commits from fixReconnect into trunk 2021-06-16 19:03:23 +00:00
Owner

reconnect unbroken, and now the app handles race conditions on reconnect and start

reconnect unbroken, and now the app handles race conditions on reconnect and start
Owner
Drone Build Status: success https://build.openprivacy.ca/flutter/libcwtch-go/199
Owner

I feel there should probably also be a check that application != nil in reconnect since that is the fundemental cause of the error, even if many of the possible paths to triggering it is a race between start and reconnect.

Reconnect should fail if application is nil and be replaced by start, rather than only executing once start has finished.

I feel there should probably also be a check that `application != nil` in reconnect since that is the fundemental cause of the error, even if many of the possible paths to triggering it is a race between start and reconnect. Reconnect should fail if application is nil and be replaced by start, rather than only executing once start has finished.
Owner
Drone Build Status: success https://build.openprivacy.ca/flutter/libcwtch-go/200
sarah merged commit abe06912a1 into trunk 2021-06-16 19:03:23 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: flutter/libcwtch-go#54
No description provided.