openprivacy
/
bine
3
0
Fork 0
Code Issues Pull Requests Releases 5 Wiki Activity

Fix Tails/OnionGrater Quoted Response Issue #2

Merged
sarah merged 1 commits from tails into trunk 2023-04-05 02:09:27 +00:00
Conversation 0 Commits 1 Files Changed 4 +23 -8
sarah commented 2023-04-04 22:29:33 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2023-04-04 22:29:33 +00:00
sarah force-pushed tails from a982303732 to a68c0fd160 2023-04-04 22:40:11 +00:00 Compare
dan requested changes 2023-04-05 00:11:52 +00:00
torutil/string.go
@ -71,3 +71,3 @@
return "", fmt.Errorf("Missing quotes")
}
return UnescapeSimpleQuotedStringContents(str[1 : len(str)-1])
if str, err := UnescapeSimpleQuotedStringContents(str[1 : len(str)-1]); err == nil {
dan commented 2023-04-05 00:11:43 +00:00
Owner
Copy Link

i assume this was here for debuging? but can be reverted, seems to do nothing?

i assume this was here for debuging? but can be reverted, seems to do nothing?
dan commented 2023-04-05 00:14:13 +00:00
Owner
Copy Link

ah i see, below you also return no error, so you're entierly suppressing the last possible error here?

is that always going to be good outside onion-grater situations?

ah i see, below you also return no error, so you're entierly suppressing the last possible error here? is that always going to be good outside onion-grater situations?
dan approved these changes 2023-04-05 00:40:42 +00:00
sarah merged commit e2dda25e37 into trunk 2023-04-05 02:09:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/bine#2
No description provided.
Delete Branch "tails"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?