openprivacy
/
connectivity
3
0
Fork 2
Code Issues 1 Pull Requests 1 Releases 35 Wiki Activity

torProvider now also consults network-liveness #1

Merged
sarah merged 1 commits from networkStatus into master 2020-05-08 21:25:44 +00:00
Conversation 0 Commits 1 Files Changed 5 +83 -36
dan commented 2020-05-08 18:57:02 +00:00
Owner
Copy Link
No description provided.
sarah was assigned by dan 2020-05-08 18:57:02 +00:00
sarah reviewed 2020-05-08 19:08:32 +00:00
sarah left a comment
Owner
Copy Link

Did you also mean to add quality.sh and tests.sh?

Did you also mean to add quality.sh and tests.sh?
tor/torProvider.go Outdated
@ -312,6 +353,13 @@ func (tp *torProvider) monitorRestart() {
}
func (tp *torProvider) restart() {
tp.lock.Lock()
sarah commented 2020-05-08 19:07:37 +00:00
Owner
Copy Link

should probably defer unlock here since we return from multiple points, or otherwise reformat to remove the multiple paths

should probably defer unlock here since we return from multiple points, or otherwise reformat to remove the multiple paths
sarah closed this pull request 2020-05-08 21:25:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
sarah
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/connectivity#1
No description provided.
Delete Branch "networkStatus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?