Clarified and Split Apart Environment Variables that alter port binding behaviour. #47

Merged
sarah merged 7 commits from whonix into master 2023-08-18 21:03:41 +00:00
Owner
No description provided.
dan was assigned by sarah 2023-08-16 17:50:28 +00:00
sarah added 4 commits 2023-08-16 17:50:29 +00:00
sarah added 1 commit 2023-08-16 17:57:00 +00:00
sarah added 1 commit 2023-08-16 17:59:38 +00:00
continuous-integration/drone/pr Build is pending Details
d8dd82d065
Update Docs
dan reviewed 2023-08-17 16:54:42 +00:00
@ -272,2 +272,3 @@
var err error
if bineWhonix := os.Getenv("BINE_WHONIX"); strings.ToLower(bineWhonix) == "true" {
if cwtchRestrictPorts := os.Getenv("CWTCH_RESTRICT_PORTS"); strings.ToLower(cwtchRestrictPorts) == "true" {
Owner

from the docs i thought i could specify the range on the cmd line. can't we just change this to an .exists() check as a flag? any value means it was set?

from the docs i thought i could specify the range on the cmd line. can't we just change this to an `.exists()` check as a flag? any value means it was set?
Author
Owner

I'd rather be explicit. Someone setting this to "false" should not be surprised.

I'd rather be explicit. Someone setting this to "false" should not be surprised.
dan marked this conversation as resolved
@ -274,0 +274,4 @@
if cwtchRestrictPorts := os.Getenv("CWTCH_RESTRICT_PORTS"); strings.ToLower(cwtchRestrictPorts) == "true" {
// for whonix like systems we tightly restrict possible listen...
// pick a random port between 15000 and 15378
// cwtch = 63 *77 *74* 63* 68 = 1537844616
Owner

dont understand this line

dont understand this line
Author
Owner

I had to pick a subrange of ports (technically we could allow these to be configurable, but the additional complexity does not seem worth it atm), and this how I arrived at the top range.

I had to pick a subrange of ports (technically we could allow these to be configurable, but the additional complexity does not seem worth it atm), and this how I arrived at the top range.
dan marked this conversation as resolved
@ -274,0 +275,4 @@
// for whonix like systems we tightly restrict possible listen...
// pick a random port between 15000 and 15378
// cwtch = 63 *77 *74* 63* 68 = 1537844616
log.Infof("using restricted ports, CWTCH_RESTRICT_PORTS=true");
Owner

since its not a specified range, why not call it WHONIX_PORTS since thats what it is

since its not a specified range, why not call it WHONIX_PORTS since thats what it is
Author
Owner

there are other possible usecases for this flag e.g. any containerized OS, not just whonix.

there are other possible usecases for this flag e.g. any containerized OS, not just whonix.
dan marked this conversation as resolved
Owner

ah ok i misunderstoond, this feature scopes cwtch to arbitrary 15000 to 15378, which isnt whonix specific, we i assume config that for whonix in a config elsewhere? it's not a whonix requirement to use those exact ports?

ah ok i misunderstoond, this feature scopes cwtch to arbitrary 15000 to 15378, which isnt whonix specific, we i assume config that for whonix in a config elsewhere? it's not a whonix requirement to use those exact ports?
dan approved these changes 2023-08-18 19:52:29 +00:00
sarah added 1 commit 2023-08-18 21:03:34 +00:00
continuous-integration/drone/pr Build is pending Details
cd87779e87
Merge branch 'master' into whonix
sarah merged commit 1524e78a4a into master 2023-08-18 21:03:41 +00:00
Sign in to join this conversation.
No reviewers
dan
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/connectivity#47
No description provided.