openprivacy
/
connectivity
3
0
Fork 2
Code Issues 1 Pull Requests 1 Releases 35 Wiki Activity

Sketch of Tor Authenticator - Fixes #6 #8

Merged
dan merged 1 commits from authenticator into master 2020-06-29 19:10:48 +00:00
Conversation 5 Commits 1 Files Changed 9 +131 -15
sarah commented 2020-06-25 20:46:54 +00:00
Owner
Copy Link

Fixes #6

Fixes #6
buildbot commented 2020-06-25 21:01:38 +00:00
First-time contributor
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/openprivacy/connectivity/13

Drone Build Status: failure https://build.openprivacy.ca/openprivacy/connectivity/13
buildbot commented 2020-06-25 21:15:56 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/connectivity/16

Drone Build Status: success https://build.openprivacy.ca/openprivacy/connectivity/16
dan was assigned by sarah 2020-06-25 21:16:41 +00:00
sarah changed title from Sketch of Tor Authenticator to Sketch of Tor Authenticator - Fixes #6 2020-06-29 15:46:30 +00:00
dan commented 2020-06-29 18:36:32 +00:00
Owner
Copy Link

Is the goal to always use authentication? If so then we could still have a default authenticator and control port object.

I'd rather still see a simple point of entry for ACN use, so keep the NewTorACN(appDirectory string, bundledTorPath string) signature and add a NewTorACNWithAuth(appDirectory string, bundledTorPath string, controlPort int, authenticator Authenticator) that the first can redirect to with defaults

Is the goal to always use authentication? If so then we could still have a default authenticator and control port object. I'd rather still see a simple point of entry for ACN use, so keep the `NewTorACN(appDirectory string, bundledTorPath string)` signature and add a `NewTorACNWithAuth(appDirectory string, bundledTorPath string, controlPort int, authenticator Authenticator)` that the first can redirect to with defaults
dan requested changes 2020-06-29 18:36:46 +00:00
testing/torrc Outdated
@ -0,0 +1,5 @@
SOCKSPort 9050
ControlPort 9051
HashedControlPassword 16:848CFDB693D95D6360DF71363AF1B90EDEB6BC5AA6A9A254E8E976CEBA
dan commented 2020-06-29 18:31:42 +00:00
Owner
Copy Link

Add a comment with the password for anyone else writing tests to use?

Add a comment with the password for anyone else writing tests to use?
buildbot commented 2020-06-29 18:45:23 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/connectivity/18

Drone Build Status: success https://build.openprivacy.ca/openprivacy/connectivity/18
buildbot commented 2020-06-29 18:46:36 +00:00
First-time contributor
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/openprivacy/connectivity/20

Drone Build Status: success https://build.openprivacy.ca/openprivacy/connectivity/20
dan closed this pull request 2020-06-29 19:10:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/connectivity#8
No description provided.
Delete Branch "authenticator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?