chore(lint): various code liniting changes

This commit is contained in:
Jon Samwell 2021-05-25 17:16:27 +10:00
parent 6d54ef7799
commit 359c800e54
3 changed files with 5 additions and 9 deletions

View File

@ -1 +1 @@
{"info":"This is a generated file; do not edit or check into version control.","plugins":{"ios":[{"name":"integration_test","path":"C:\\\\Google\\\\flutter\\\\packages\\\\integration_test\\\\","dependencies":[]}],"android":[{"name":"integration_test","path":"C:\\\\Google\\\\flutter\\\\packages\\\\integration_test\\\\","dependencies":[]}],"macos":[],"linux":[],"windows":[],"web":[]},"dependencyGraph":[{"name":"integration_test","dependencies":[]}],"date_created":"2021-05-25 17:13:13.998769","version":"2.2.0"}
{"info":"This is a generated file; do not edit or check into version control.","plugins":{"ios":[{"name":"integration_test","path":"C:\\\\Google\\\\flutter\\\\packages\\\\integration_test\\\\","dependencies":[]}],"android":[{"name":"integration_test","path":"C:\\\\Google\\\\flutter\\\\packages\\\\integration_test\\\\","dependencies":[]}],"macos":[],"linux":[],"windows":[],"web":[]},"dependencyGraph":[{"name":"integration_test","dependencies":[]}],"date_created":"2021-05-25 17:16:18.323118","version":"2.2.0"}

View File

@ -146,9 +146,7 @@ class FlutterDriverTestConfiguration extends FlutterTestConfiguration {
world = world ?? FlutterDriverWorld();
final driver = await createFlutterDriver(
flutterConfig.runningAppProtocolEndpointUri != null &&
flutterConfig.runningAppProtocolEndpointUri != null &&
flutterConfig.runningAppProtocolEndpointUri!.isNotEmpty
flutterConfig.runningAppProtocolEndpointUri?.isNotEmpty ?? false
? flutterConfig.runningAppProtocolEndpointUri
: null,
);
@ -204,15 +202,14 @@ class FlutterDriverTestConfiguration extends FlutterTestConfiguration {
}
void _ensureCorrectConfiguration() {
if (runningAppProtocolEndpointUri != null &&
runningAppProtocolEndpointUri!.isNotEmpty) {
if (runningAppProtocolEndpointUri?.isNotEmpty ?? false) {
if (restartAppBetweenScenarios) {
throw AssertionError(
'Cannot restart app between scenarios if using runningAppProtocolEndpointUri',
);
}
if (targetDeviceId != null && targetDeviceId!.isNotEmpty) {
if (targetDeviceId?.isNotEmpty ?? false) {
throw AssertionError(
'Cannot target specific device id if using runningAppProtocolEndpointUri',
);

View File

@ -60,8 +60,7 @@ class FlutterAppRunnerHook extends Hook {
}
Future<void> _runApp(FlutterDriverTestConfiguration config) async {
if (config.runningAppProtocolEndpointUri != null &&
config.runningAppProtocolEndpointUri!.isNotEmpty) {
if (config.runningAppProtocolEndpointUri?.isNotEmpty ?? false) {
stdout.writeln(
"Connecting to running Flutter app under test at '${config.runningAppProtocolEndpointUri}', "
'this might take a few moments',