openprivacy
/
fuzzytags
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bench Compilation #3

New Issue
Closed
opened 2021-08-16 22:26:45 +00:00 by thomas · 5 comments
thomas commented 2021-08-16 22:26:45 +00:00
Copy Link

Hello!

When compiling using "cargo bench", I got the following errors:

error[E0557]: feature has been removed
 --> src/lib.rs:2:12
  |
2 | #![feature(external_doc)]
  |            ^^^^^^^^^^^^ feature has been removed
  |
  = note: use #[doc = include_str!("filename")] instead, which handles macro invocations

warning: unknown `doc` attribute `include`
 --> src/lib.rs:3:8
  |
3 | #![doc(include = "../README.md")]
  | -------^^^^^^^^^^^^^^^^^^^^^^^^-- help: use `doc = include_str!` instead: `#![doc = include_str!("../README.md")]`
  |
  = note: `#[warn(invalid_doc_attributes)]` on by default
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
  = note: for more information, see issue #82730 <https://github.com/rust-lang/rust/issues/82730>

warning: unknown `doc` attribute `include`
 --> src/lib.rs:4:8
  |
4 | #![doc(include = "../ANONYMITY.md")]
  | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^-- help: use `doc = include_str!` instead: `#![doc = include_str!("../ANONYMITY.md")]`
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
  = note: for more information, see issue #82730 <https://github.com/rust-lang/rust/issues/82730>

For more information about this error, try `rustc --explain E0557`.
warning: `fuzzytags` (lib) generated 2 warnings
error: could not compile `fuzzytags` due to previous error; 2 warnings emitted
warning: build failed, waiting for other jobs to finish...
    Building [=======================> ] 110/114: criterion

error: build failed

I tried rustup default nightly and then run but doesn't work.

Thank you!

Hello! When compiling using "cargo bench", I got the following errors: ``` error[E0557]: feature has been removed --> src/lib.rs:2:12 | 2 | #![feature(external_doc)] | ^^^^^^^^^^^^ feature has been removed | = note: use #[doc = include_str!("filename")] instead, which handles macro invocations warning: unknown `doc` attribute `include` --> src/lib.rs:3:8 | 3 | #![doc(include = "../README.md")] | -------^^^^^^^^^^^^^^^^^^^^^^^^-- help: use `doc = include_str!` instead: `#![doc = include_str!("../README.md")]` | = note: `#[warn(invalid_doc_attributes)]` on by default = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #82730 <https://github.com/rust-lang/rust/issues/82730> warning: unknown `doc` attribute `include` --> src/lib.rs:4:8 | 4 | #![doc(include = "../ANONYMITY.md")] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^-- help: use `doc = include_str!` instead: `#![doc = include_str!("../ANONYMITY.md")]` | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #82730 <https://github.com/rust-lang/rust/issues/82730> For more information about this error, try `rustc --explain E0557`. warning: `fuzzytags` (lib) generated 2 warnings error: could not compile `fuzzytags` due to previous error; 2 warnings emitted warning: build failed, waiting for other jobs to finish... Building [=======================> ] 110/114: criterion error: build failed ``` I tried ```rustup default nightly``` and then run but doesn't work. Thank you!
sarah commented 2021-08-16 23:01:24 +00:00
Owner
Copy Link

Thanks for reporting!

Looks like rust removed the externaldoc feature and quite a few things haven't updated yet.

I just pushed a commit (7e8428cb6e) which fixes all of the issues except benchamrking simd which is still broken due to an upstream dependency.

Will keep this open until everything compiles again.

Thanks for reporting! Looks like rust removed the externaldoc feature and quite a few things haven't updated yet. I just pushed a commit (https://git.openprivacy.ca/openprivacy/fuzzytags/commit/7e8428cb6ee367b3a4e0f37d152e574fe03c361b) which fixes all of the issues *except* benchamrking `simd` which is still broken due to an upstream dependency. Will keep this open until everything compiles again.
sarah commented 2021-08-16 23:35:15 +00:00
Owner
Copy Link

Ok I published a 0.6.0 version with switch dependencies that should now build on the latest Rust.

Ok I published a 0.6.0 version with switch dependencies that should now build on the latest Rust.
thomas commented 2021-08-17 00:00:50 +00:00
Author
Copy Link

Thank you for your reply!

Here is the new result when running "cargo bench"

warning: unused import: `DetectionKey`
   --> src/lib.rs:619:17
    |
619 |     use crate::{DetectionKey, RootSecret, Tag};
    |                 ^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

warning: `fuzzytags` (lib test) generated 1 warning
error[E0599]: no function or associated item named `generate_entangled_tag` found for struct `TaggingKey` in the current scope
  --> benches/entangled.rs:18:29
   |
18 |                 TaggingKey::generate_entangled_tag(
   |                             ^^^^^^^^^^^^^^^^^^^^^^ function or associated item not found in `TaggingKey<{_: u8}>`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `fuzzytags` due to previous error
Thank you for your reply! Here is the new result when running "cargo bench" ``` warning: unused import: `DetectionKey` --> src/lib.rs:619:17 | 619 | use crate::{DetectionKey, RootSecret, Tag}; | ^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default warning: `fuzzytags` (lib test) generated 1 warning error[E0599]: no function or associated item named `generate_entangled_tag` found for struct `TaggingKey` in the current scope --> benches/entangled.rs:18:29 | 18 | TaggingKey::generate_entangled_tag( | ^^^^^^^^^^^^^^^^^^^^^^ function or associated item not found in `TaggingKey<{_: u8}>` For more information about this error, try `rustc --explain E0599`. error: could not compile `fuzzytags` due to previous error ```
sarah commented 2021-08-17 00:07:35 +00:00
Owner
Copy Link

Ah yeah I updated the README for those:

You need to run cargo bench --bench fuzzy_tags_benches for the basic benchmarks

OR cargo bench --features "entangled" --bench entangled for entangling benchmarks

OR env RUSTFLAGS="-C target_feature=+avx2" cargo bench --features "simd,entangled" --bench fuzzy_tags_benches

For avx2 benchmarks.

Hopefully that helps!

Ah yeah I updated the README for those: You need to run `cargo bench --bench fuzzy_tags_benches` for the basic benchmarks OR `cargo bench --features "entangled" --bench entangled` for entangling benchmarks OR `env RUSTFLAGS="-C target_feature=+avx2" cargo bench --features "simd,entangled" --bench fuzzy_tags_benches` For avx2 benchmarks. Hopefully that helps!
thomas commented 2021-08-17 00:13:55 +00:00
Author
Copy Link

Yes it works.

Sorry for missing that!

Thank you so much!

Yes it works. Sorry for missing that! Thank you so much!
sarah closed this issue 2021-08-17 19:10:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
trunk
tweaked_hashes
nightlyfix
perf
const_generics
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/fuzzytags#3
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?