From 71685b9c3ae79f3d6ec0c28651e26d9d1152ee12 Mon Sep 17 00:00:00 2001 From: Sarah Jamie Lewis Date: Tue, 16 Jan 2018 12:13:46 -0500 Subject: [PATCH] Bugfix: Repeated channel opening attempts failed because err was shadowed --- connection/connection.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connection/connection.go b/connection/connection.go index ac3d3f4..a493f5c 100644 --- a/connection/connection.go +++ b/connection/connection.go @@ -223,7 +223,6 @@ func (rc *Connection) handleChannelOpening(channel *channels.Channel, response [ } func (rc *Connection) buildChannel(handler channels.Handler, openChannelFunc func(handler channels.Handler) (*channels.Channel, error)) (*channels.Channel, error) { - err := rc.am.Authorized(handler.RequiresAuthentication()) if err == nil { channel, err := openChannelFunc(handler) @@ -240,6 +239,7 @@ func (rc *Connection) buildChannel(handler channels.Handler, openChannelFunc fun } return channel, nil } + return nil, err } return nil, err }