From a998ebc935cfd9d370fc2576f44210bc81cb82e7 Mon Sep 17 00:00:00 2001 From: erinn Date: Wed, 16 Dec 2020 17:34:15 -0800 Subject: [PATCH] addressing comments on #36 --- Collapser.qml | 4 ++-- EmojiDrawer.qml | 1 - Portrait.qml | 1 - ToggleSwitch.qml | 8 +------- 4 files changed, 3 insertions(+), 11 deletions(-) diff --git a/Collapser.qml b/Collapser.qml index 1947d9e..baa7cac 100644 --- a/Collapser.qml +++ b/Collapser.qml @@ -6,9 +6,9 @@ import "theme" Opaque.Column { id: root - //: Show ▼ + //: Show readonly property string strShow: qsTr("collapser-show") - //: Hide ▲ + //: Hide readonly property string strHide: qsTr("collapser-hide") property string textShow: strShow diff --git a/EmojiDrawer.qml b/EmojiDrawer.qml index 1228002..c511e00 100644 --- a/EmojiDrawer.qml +++ b/EmojiDrawer.qml @@ -193,7 +193,6 @@ Item { height: root.size * 0.8 color: Theme.dividerColor visible: !root.narrowMode && !root.searchMode - //anchors.verticalCenter: parent.verticalCenter } Item { diff --git a/Portrait.qml b/Portrait.qml index 645dbf4..2d4e3fa 100644 --- a/Portrait.qml +++ b/Portrait.qml @@ -29,7 +29,6 @@ Item { Rectangle { id: mainImage - //anchors.leftMargin: baseWidth * 0.1 anchors.horizontalCenter: parent.horizontalCenter anchors.verticalCenter: parent.verticalCenter width: parent.width * 0.8 diff --git a/ToggleSwitch.qml b/ToggleSwitch.qml index f0ce42c..7e9274a 100644 --- a/ToggleSwitch.qml +++ b/ToggleSwitch.qml @@ -3,12 +3,8 @@ import QtQuick.Controls.Styles 1.4 import QtQuick 2.12 import "theme" -// ToggleSwtch implements a stylized toggle switch. It requires the user create a function called onToggled to -// perform any additional operations needed to define the behavior of the toggle switch +// ToggleSwtch implements a stylized toggle switch. Switch { - //property bool isToggled - //property var onToggled: function () { console.log("In Superclass") }; - //checked: isToggled style: SwitchStyle { handle: Rectangle { implicitWidth: 25 @@ -25,8 +21,6 @@ Switch { color: checked ? Theme.toggleOnColor :Theme.toggleOffColor } } - - //onClicked: function() {onToggled()} }