openprivacy
/
opaque
3
0
Fork 0
Code Issues 3 Pull Requests 1 Releases Wiki Activity

new scaling system pass one #36

Merged
dan merged 3 commits from newscale into master 2020-12-17 01:48:48 +00:00
Conversation 0 Commits 3 Files Changed 16 +198 -135
erinn commented 2020-12-15 01:23:32 +00:00
Owner
Copy Link
No description provided.
sarah reviewed 2020-12-15 01:27:51 +00:00
EmojiDrawer.qml Outdated
@ -194,3 +194,3 @@
color: Theme.dividerColor
visible: !root.narrowMode && !root.searchMode
anchors.verticalCenter: parent.verticalCenter
//anchors.verticalCenter: parent.verticalCenter
sarah commented 2020-12-15 01:27:51 +00:00
Owner
Copy Link

delete?

delete?
erinn marked this conversation as resolved
sarah reviewed 2020-12-15 01:28:27 +00:00
ToggleSwitch.qml Outdated
@ -9,3 +9,1 @@
property bool isToggled
property var onToggled: function () { console.log("In Superclass") };
checked: isToggled
//property bool isToggled
sarah commented 2020-12-15 01:28:27 +00:00
Owner
Copy Link

Uncomment or fixup?

Uncomment or fixup?
erinn marked this conversation as resolved
dan requested changes 2020-12-15 01:42:04 +00:00
dan left a comment
Owner
Copy Link

wow, looks good. two small comments

wow, looks good. two small comments
Collapser.qml Outdated
@ -0,0 +8,4 @@
//: Show ▼
readonly property string strShow: qsTr("collapser-show")
//: Hide ▲
dan commented 2020-12-15 01:37:20 +00:00
Owner
Copy Link

the ▼ ▲ are added later so not needed in the translation guidance?

the ▼ ▲ are added later so not needed in the translation guidance?
erinn marked this conversation as resolved
Portrait.qml
@ -30,4 +29,4 @@
Rectangle {
id: mainImage
//anchors.leftMargin: baseWidth * 0.1
dan commented 2020-12-15 01:38:59 +00:00
Owner
Copy Link

sorry not you did but near by, delete?

sorry not you did but near by, delete?
erinn marked this conversation as resolved
erinn referenced this issue from a commit 2020-12-17 01:34:27 +00:00
addressing comments on #36
dan merged commit 136e613ab5 into master 2020-12-17 01:48:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: openprivacy/opaque#36
No description provided.
Delete Branch "newscale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?