sarah
/
ristretto255
mirror of https://github.com/gtank/ristretto255
1
0
Fork 0
Code Issues Releases Wiki Activity

internal/scalar: fix high bit check 

This should check that s[31] > 127 to determine whether the high bit is set
(instead of s[31] >= 127)
This commit is contained in:
Henry de Valence 2019-05-10 16:46:03 -07:00 committed by Filippo Valsorda
parent de058a3840
commit 4642a7ca28
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/scalar/scalar.go
View File

@ -898,7 +898,7 @@ func (s *Scalar) NonAdjacentForm(w uint) [256]int8 {
// This implementation is adapted from the one
// in curve25519-dalek and is documented there:
// https://github.com/dalek-cryptography/curve25519-dalek/blob/f630041af28e9a405255f98a8a93adca18e4315b/src/scalar.rs#L800-L871
if s[31] >= 127 {
if s[31] > 127 {
panic("scalar has high bit set illegally")
}
if w < 2 {
@ -959,7 +959,7 @@ func (s *Scalar) NonAdjacentForm(w uint) [256]int8 {
}
func (s *Scalar) SignedRadix16() [64]int8 {
if s[31] >= 127 {
if s[31] > 127 {
panic("scalar has high bit set illegally")
}