From 675dee67e62590201d0329558c2f1bb2333f3649 Mon Sep 17 00:00:00 2001 From: Filippo Valsorda Date: Fri, 19 Apr 2019 17:11:44 -0400 Subject: [PATCH] ristretto255: do not modify the receiver if Decode fails --- ristretto255.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ristretto255.go b/ristretto255.go index 3fedc79..03ea68c 100644 --- a/ristretto255.go +++ b/ristretto255.go @@ -250,7 +250,7 @@ func (e *Element) Decode(in []byte) error { // x = CT_ABS(2 * s * den_x) // y = u1 * den_y // t = x * y - out := &e.r + var out edwards25519.ExtendedGroupElement out.X.Mul(radix51.Two, s).Mul(&out.X, denX).Abs(&out.X) out.Y.Mul(u1, denY) out.Z.One() @@ -262,6 +262,7 @@ func (e *Element) Decode(in []byte) error { } // Otherwise, return the internal representation in extended coordinates (x, y, 1, t). + e.r.Set(&out) return nil }