sarah
/
tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix a pointer size error in test_bridges.c 

sizeof(ret) is the size of the pointer, not the size of what it
points to.  Fortunately, we already have a function to compare
tor_addr_port_t values for equality.

Bugfix on c2c5b13e5d8a77e; bug not in any released Tor. Found by
clang's scan-build.
This commit is contained in:
Nick Mathewson 2018-04-17 19:44:09 -04:00
parent 1abe0a5769
commit 3bf9974b6c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/test_bridges.c
View File

@ -234,7 +234,7 @@ test_bridges_get_configured_bridge_by_orports_digest(void *arg)
ret = get_configured_bridge_by_orports_digest(digest, orports);
tt_ptr_op(ret, OP_NE, NULL);
tt_mem_op(addrport1, OP_EQ, bridge_get_addr_port(ret), sizeof(ret));
tt_assert(tor_addr_port_eq(addrport1, bridge_get_addr_port(ret)));
done:
smartlist_free(orports);