sarah
/
tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clarify the message logged when a remote relay is unexpectedly missing a port 

(Users were confusing this with a local port.)

Fixes bug 20711; bugfix on 0.2.8.2-alpha.
This commit is contained in:
teor 2017-01-03 16:56:32 +11:00
parent 18f47bbb73
commit 518ef61975
No known key found for this signature in database
GPG Key ID: 450CBA7F968F094B
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
changes/bug20711
View File

@ -2,4 +2,6 @@
- Allow relays to use directory mirrors without a DirPort: these relays
need to be contacted over their ORPorts using a begindir connection.
Fixes bug 20711; bugfix on 0.2.8.2-alpha.
- Clarify the message logged when a remote relay is unexpectedly missing
an ORPort or DirPort: users were confusing this with a local port.
Fixes bug 20711; bugfix on 0.2.8.2-alpha.

4
src/or/directory.c
View File

@ -1245,9 +1245,9 @@ directory_initiate_command_rend(const tor_addr_port_t *or_addr_port,
if (!port || tor_addr_is_null(&addr)) {
static int logged_backtrace = 0;
log_warn(LD_DIR,
"Cannot make an outgoing %sconnection without %sPort.",
"Cannot make an outgoing %sconnection without a remote %sPort.",
use_begindir ? "begindir " : "",
use_begindir ? "an OR" : "a Dir");
use_begindir ? "OR" : "Dir");
if (!logged_backtrace) {
log_backtrace(LOG_INFO, LD_BUG, "Address came from");
logged_backtrace = 1;