r16690@tombo: nickm | 2008-07-03 11:03:39 -0400
Backport to 0.2.0: Fix for bug 742: do not use O_CREAT on 2-option version of open(). Especially do not use it on /dev/null. Fix from Michael Scherer. Bugfix on 0.0.2pre19 (wow). svn:r15627
This commit is contained in:
parent
aeca4d90ed
commit
5a48b4faac
|
@ -30,6 +30,9 @@ Changes in version 0.2.0.29 - 2008-06-xx
|
||||||
Fix for bug 707.
|
Fix for bug 707.
|
||||||
- Fix macro collision between OpenSSL 0.9.8h and Windows headers.
|
- Fix macro collision between OpenSSL 0.9.8h and Windows headers.
|
||||||
Fixes bug 704; fix from Steven Murdoch.
|
Fixes bug 704; fix from Steven Murdoch.
|
||||||
|
- When opening /dev/null in finish_daemonize(), do not pass the
|
||||||
|
O_CREAT flag. Fortify was complaining, and correctly so. Fixes
|
||||||
|
bug 742; fix from Michael Scherer. Bugfix on 0.0.2pre19.
|
||||||
|
|
||||||
|
|
||||||
Changes in version 0.2.0.28-rc - 2008-06-13
|
Changes in version 0.2.0.28-rc - 2008-06-13
|
||||||
|
|
|
@ -3092,8 +3092,7 @@ finish_daemon(const char *desired_cwd)
|
||||||
exit(1);
|
exit(1);
|
||||||
}
|
}
|
||||||
|
|
||||||
nullfd = open("/dev/null",
|
nullfd = open("/dev/null", O_RDWR | O_APPEND);
|
||||||
O_CREAT | O_RDWR | O_APPEND);
|
|
||||||
if (nullfd < 0) {
|
if (nullfd < 0) {
|
||||||
log_err(LD_GENERAL,"/dev/null can't be opened. Exiting.");
|
log_err(LD_GENERAL,"/dev/null can't be opened. Exiting.");
|
||||||
exit(1);
|
exit(1);
|
||||||
|
|
Loading…
Reference in New Issue