sarah
/
tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix month check in parse_http_time, add test

This commit is contained in:
Sebastian Hahn 2012-03-09 15:40:44 +01:00 committed by Nick Mathewson
parent 801923ac21
commit 679aa93e23
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/util.c
View File

@ -1451,6 +1451,8 @@ parse_http_time(const char *date, struct tm *tm)
month[3] = '\0';
/* Okay, now decode the month. */
/* set tm->tm_mon to dummy value so the check below fails. */
tm->tm_mon = -1;
for (i = 0; i < 12; ++i) {
if (!strcasecmp(MONTH_NAMES[i], month)) {
tm->tm_mon = i;

4
src/test/test_util.c
View File

@ -121,6 +121,10 @@ test_util_parse_http_time(void *arg)
test_eq((time_t)775961302UL, tor_timegm(&a_time));
test_eq(0, parse_http_time("Mie Aug 4 0:48:22 1994", &a_time));
test_eq((time_t)775961302UL, tor_timegm(&a_time));
test_eq(0, parse_http_time("Sun, 1 Jan 2012 00:00:00 GMT", &a_time));
test_eq((time_t)1325376000UL, tor_timegm(&a_time));
test_eq(0, parse_http_time("Mon, 31 Dec 2012 00:00:00 GMT", &a_time));
test_eq((time_t)1356912000UL, tor_timegm(&a_time));
test_eq(-1, parse_http_time("2004-08-zz 99-99x99 GMT", &a_time));
test_eq(-1, parse_http_time("2011-03-32 00:00:00 GMT", &a_time));
test_eq(-1, parse_http_time("2011-03-30 24:00:00 GMT", &a_time));