Having a ControlPort open doesn't mean we are a client

The options_any_client_port_set() returns true if the ControlPort is set which
is wrong because we can have that port open but still not behave as a tor
client (like many relays for instance).

Fixes #26062

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2018-04-25 13:43:37 -04:00
parent 01ffe8e2f4
commit 67a41b6306
2 changed files with 4 additions and 1 deletions

4
changes/ticket26062 Normal file
View File

@ -0,0 +1,4 @@
o Minor bugfixes (client):
- Don't consider Tor running as a client if the ControlPort is open. Fixes
bug 26062; bugfix on 0.2.9.4-alpha.

View File

@ -8443,7 +8443,6 @@ options_any_client_port_set(const or_options_t *options)
return (options->SocksPort_set ||
options->TransPort_set ||
options->NATDPort_set ||
options->ControlPort_set ||
options->DNSPort_set ||
options->HTTPTunnelPort_set);
}