Remove a redundant check in ..transition_affects_guards()

scan-build found that we we checking UseEntryGuards twice.

Fixes bug 21492.
This commit is contained in:
Nick Mathewson 2017-02-17 11:46:38 -05:00
parent 5dbbd6bc39
commit 823fb68a14
2 changed files with 5 additions and 1 deletions

5
changes/bug21492 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (correctness):
- Remove a redundant check for the UseEntryGuards option from the
options_transition_affects_guards() function. Fixes bug 21492;
bugfix on 0.3.0.1-alpha.

View File

@ -1587,7 +1587,6 @@ options_transition_affects_guards(const or_options_t *old,
return
(old->UseEntryGuards != new->UseEntryGuards ||
old->UseBridges != new->UseBridges ||
old->UseEntryGuards != new->UseEntryGuards ||
old->ClientUseIPv4 != new->ClientUseIPv4 ||
old->ClientUseIPv6 != new->ClientUseIPv6 ||
old->FascistFirewall != new->FascistFirewall ||