sarah
/
tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use a macro to indicate "The ecdhe group we use by default". 

This might make Coverity happier about the if statement where we
have a default case that's the same as one of the other cases. CID 1248515
This commit is contained in:
Nick Mathewson 2014-10-20 09:08:42 -04:00
parent 2d4c40ee5f
commit affa251c83
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/tortls.c
View File

@ -1170,6 +1170,9 @@ tor_tls_context_init_one(tor_tls_context_t **ppcontext,
return ((new_ctx != NULL) ? 0 : -1);
}
/** The group we should use for ecdhe when none was selected. */
#define NID_tor_default_ecdhe_group NID_X9_62_prime256v1
/** Create a new TLS context for use with Tor TLS handshakes.
* <b>identity</b> should be set to the identity key used to sign the
* certificate.
@ -1365,7 +1368,7 @@ tor_tls_context_new(crypto_pk_t *identity, unsigned int key_lifetime,
else if (flags & TOR_TLS_CTX_USE_ECDHE_P256)
nid = NID_X9_62_prime256v1;
else
nid = NID_X9_62_prime256v1;
nid = NID_tor_default_ecdhe_group;
/* Use P-256 for ECDHE. */
ec_key = EC_KEY_new_by_curve_name(nid);
if (ec_key != NULL) /*XXXX Handle errors? */