sarah
/
tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Backport of r15149: you can't strcasecmp on 20-byte digests 

what if they contain nuls?
(worse, what if they *don't* contain nuls? ;) 

svn:r15152
This commit is contained in:
Karsten Loesing 2008-06-11 23:44:13 +00:00
parent 1fde6994d5
commit b3aaa47d3e
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -21,6 +21,9 @@ Changes in version 0.2.0.28-rc - 2008-06-??
bug 688, reported by mfr.
- Fix unit tests in 0.2.0.27-rc.
- Fix compile on Windows.
- While setting up a hidden service, some valid introduction circuits
were overlooked and given up. This might be the reason for the long
delay in making a hidden service available. Bugfix on 0.2.0.13-alpha.
Changes in version 0.2.0.27-rc - 2008-06-03

8
src/or/rendservice.c
View File

@ -1026,8 +1026,8 @@ find_intro_circuit(rend_intro_point_t *intro, const char *pk_digest,
tor_assert(intro);
while ((circ = circuit_get_next_by_pk_and_purpose(circ,pk_digest,
CIRCUIT_PURPOSE_S_INTRO))) {
if (!strcasecmp(circ->build_state->chosen_exit->identity_digest,
intro->extend_info->identity_digest) &&
if (!memcmp(circ->build_state->chosen_exit->identity_digest,
intro->extend_info->identity_digest, DIGEST_LEN) &&
circ->rend_desc_version == desc_version) {
return circ;
}
@ -1036,8 +1036,8 @@ find_intro_circuit(rend_intro_point_t *intro, const char *pk_digest,
circ = NULL;
while ((circ = circuit_get_next_by_pk_and_purpose(circ,pk_digest,
CIRCUIT_PURPOSE_S_ESTABLISH_INTRO))) {
if (!strcasecmp(circ->build_state->chosen_exit->identity_digest,
intro->extend_info->identity_digest) &&
if (!memcmp(circ->build_state->chosen_exit->identity_digest,
intro->extend_info->identity_digest, DIGEST_LEN) &&
circ->rend_desc_version == desc_version) {
return circ;
}