sarah
/
tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix comment about TLSv1_method() per comments by wanoskarnet

This commit is contained in:
Nick Mathewson 2012-01-09 16:40:21 -05:00
parent 6fd61cf767
commit c78a314e95
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/common/tortls.c
View File

@ -777,15 +777,10 @@ tor_tls_context_new(crypto_pk_env_t *identity, unsigned int key_lifetime,
}
#if 0
/* Tell OpenSSL to only use TLS1. This would actually break compatibility
* with clients that are configured to use SSLv23_method(), so we should
* probably never use it.
*/
/* XXX wanoskarnet says this comment is bunk -- that even if we turn
* this line on, clients configured to use SSLv23 would still able to
* talk to us. But he also says it's ok to leave it out. I suggest we
* delete this whole clause (the one that's #if 0'ed out). I'll leave
* it in place until Nick expresses an opinion. -RD */
/* Tell OpenSSL to only use TLS1. This may have subtly different results
* from SSLv23_method() with SSLv2 and SSLv3 disabled, so we need to do some
* investigation before we consider adjusting it. It should be compatible
* with existing Tors. */
if (!(result->ctx = SSL_CTX_new(TLSv1_method())))
goto error;
#endif