Mark the 1-per-sec update_current_time() call as redundant.

We still do this time update here, since we do it from all
callbacks, but it is no longer a reason to keep the once-per-second
callback enabled.

Closes ticket 26009.
This commit is contained in:
Nick Mathewson 2018-05-03 12:23:55 -04:00
parent 285e7c98fd
commit c9f07f36bf
2 changed files with 14 additions and 1 deletions

9
changes/ticket26009 Normal file
View File

@ -0,0 +1,9 @@
o Minor features (mainloop):
- Move responsibility for
keeping track of Tor's uptime
from a nce-per-second callback to a callback that is only scheduled as
needed. Once enough items are removed from our once-per-second
callback, we can eliminate it entirely to conserve CPU when idle.
Closes ticket
26009.

View File

@ -2576,8 +2576,12 @@ second_elapsed_callback(periodic_timer_t *timer, void *arg)
n_libevent_errors = 0;
/* log_notice(LD_GENERAL, "Tick."); */
now = time(NULL);
/* We don't need to do this once-per-second any more: time-updating is
* only in this callback _because it is a callback_. It should be fine
* to disable this callback, and the time will still get updated.
*/
update_current_time(now);
/* the second has rolled over. check more stuff. */