sarah
/
tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Only disable -Wfloat-conversion on mingw when it exists. 

The 22081 fix disabled -Wfloat-conversion, but -Wfloat-conversion
didn't exist in every relevant mingw; it was added in GCC 4.9.x some
time, if the documentation can be trusted.

Bug not in any released version of tor.
This commit is contained in:
Nick Mathewson 2017-07-05 16:10:45 -04:00
parent 32c0066e4b
commit dfc0614840
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/util.c
View File

@ -5695,13 +5695,14 @@ clamp_double_to_int64(double number)
{ {
int exponent; int exponent;
#if defined(__MINGW32__) || defined(__MINGW64__) #if (defined(__MINGW32__) || defined(__MINGW64__)) && GCC_VERSION >= 409
/* /*
Mingw's math.h uses gcc's __builtin_choose_expr() facility to declare Mingw's math.h uses gcc's __builtin_choose_expr() facility to declare
isnan, isfinite, and signbit. But as implemented in at least some isnan, isfinite, and signbit. But as implemented in at least some
versions of gcc, __builtin_choose_expr() can generate type warnings versions of gcc, __builtin_choose_expr() can generate type warnings
even from branches that are not taken. So, suppress those warnings. even from branches that are not taken. So, suppress those warnings.
*/ */
#define PROBLEMATIC_FLOAT_CONVERSION_WARNING
DISABLE_GCC_WARNING(float-conversion) DISABLE_GCC_WARNING(float-conversion)
#endif #endif
/* NaN is a special case that can't be used with the logic below. */ /* NaN is a special case that can't be used with the logic below. */
@ -5729,7 +5730,7 @@ DISABLE_GCC_WARNING(float-conversion)
/* Handle infinities and finite numbers with magnitude >= 2^63. */ /* Handle infinities and finite numbers with magnitude >= 2^63. */
return signbit(number) ? INT64_MIN : INT64_MAX; return signbit(number) ? INT64_MIN : INT64_MAX;
#if defined(__MINGW32__) || defined(__MINGW64__) #ifdef PROBLEMATIC_FLOAT_CONVERSION_WARNING
ENABLE_GCC_WARNING(float-conversion) ENABLE_GCC_WARNING(float-conversion)
#endif #endif
} }