From e17f436fff541e0c31827f0e99bd345096d276e0 Mon Sep 17 00:00:00 2001 From: George Kadianakis Date: Fri, 27 Apr 2018 15:27:44 +0300 Subject: [PATCH] Fix memleak found by unittests. --- src/or/circuitbuild.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 74e607d18..1eb3947ae 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -2633,7 +2633,9 @@ choose_good_middle_server(uint8_t purpose, /** If a hidden service circuit wants a specific middle node, pin it. */ if (middle_node_must_be_vanguard(options, purpose, cur_len)) { log_debug(LD_GENERAL, "Picking a sticky node (cur_len = %d)", cur_len); - return pick_vanguard_middle_node(options, flags, cur_len, excluded); + choice = pick_vanguard_middle_node(options, flags, cur_len, excluded); + smartlist_free(excluded); + return choice; } choice = router_choose_random_node(excluded, options->ExcludeNodes, flags);