Switch geoip_get_request_history to asprintf; fix bug 1365

This commit is contained in:
Nick Mathewson 2010-04-20 01:09:40 -04:00
parent de4a49adc2
commit f2c30e97cc
2 changed files with 6 additions and 2 deletions

4
changes/fix_bug_1365 Normal file
View File

@ -0,0 +1,4 @@
o Minor bugfixes:
- Fix a segfault when DirReqStatistics is enabled. Bug found by keb.
Fixes bug 1365; bugfix on 0.2.2.11-alpha.

View File

@ -945,8 +945,8 @@ geoip_get_request_history(time_t now, geoip_client_action_t action)
strings = smartlist_create();
SMARTLIST_FOREACH(entries, c_hist_t *, ent, {
char buf[32];
tor_snprintf(buf, sizeof(buf), "%s=%u", ent->country, ent->total);
char *buf = NULL;
tor_asprintf(&buf, "%s=%u", ent->country, ent->total);
smartlist_add(strings, buf);
});
result = smartlist_join_strings(strings, ",", 0, NULL);