sarah
/
tor
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
26,023 Commits 31 Branches 486 Tags 66 MiB
Commit Graph

26023 Commits

Author SHA1 Message Date
Nick Mathewson 65f2eec694 Correctly handle NULL returns from parse_protocol_list when voting. 
In some cases we had checked for it, but in others we had not.  One
of these cases could have been used to remotely cause
denial-of-service against directory authorities while they attempted
to vote.

Fixes TROVE-2018-001.
 2018-03-01 16:05:17 -05:00
Taylor Yu 09484b9449 Document how to allow partial Travis failures 
Add some commented-out allow_failures clauses to make it easier to
temporarily allow less-critical sub-builds to fail while still
reporting success.
 2018-03-01 13:18:33 -06:00
Nick Mathewson ce9df228a5 backport a changelog change from arma to 0.3.1 2018-02-27 18:38:21 -05:00
Nick Mathewson ff679ee066 Create initial 0.3.1.10 changelog. 2018-02-27 17:11:16 -05:00
Nick Mathewson 60d3a3c754 Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-21 11:53:50 -05:00
Nick Mathewson ac1942ac58 Update the .gitmodules to refer to project-level tor-rust-dependencies 
Closes most of #25323.
 2018-02-21 11:53:04 -05:00
Nick Mathewson 7e2e8ac245 Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-16 09:48:15 -05:00
Nick Mathewson 2bcd264a28 Merge branch 'maint-0.2.9' into maint-0.3.1 2018-02-16 09:48:11 -05:00
Nick Mathewson cb92d47dec Merge remote-tracking branch 'dgoulet/ticket24902_029_05' into maint-0.2.9 2018-02-16 09:41:06 -05:00
Nick Mathewson 7e4623a235 Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-16 08:47:41 -05:00
Nick Mathewson 3930ffdf63 Merge branch 'maint-0.2.9' into maint-0.3.1 
"ours" merge to avoid conflicts with the cherry-picked fix for 24898.
 2018-02-16 08:47:12 -05:00
Roger Dingledine d21e5cfc24 stop calling channel_mark_client in response to a create_fast 
since all it does is produce false positives

this commit should get merged into 0.2.9 and 0.3.0 *and* 0.3.1, even
though the code in the previous commit is already present in 0.3.1. sorry
for the mess.

[Cherry-picked]
 2018-02-16 08:46:57 -05:00
Roger Dingledine 2b99350ca4 stop calling channel_mark_client in response to a create_fast 
since all it does is produce false positives

this commit should get merged into 0.2.9 and 0.3.0 *and* 0.3.1, even
though the code in the previous commit is already present in 0.3.1. sorry
for the mess.
 2018-02-16 08:46:31 -05:00
Roger Dingledine 8d5dcdbda2 backport to make channel_is_client() accurate 
This commit takes a piece of commit af8cadf3a9 and a piece of commit
46fe353f25, with the goal of making channel_is_client() be based on what
sort of connection handshake the other side used, rather than seeing
whether the other side ever sent a create_fast cell to us.
 2018-02-16 08:39:10 -05:00
Nick Mathewson f0f22ad92c Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-13 16:55:19 -05:00
Nick Mathewson f647035b37 Merge branch 'maint-0.2.9' into maint-0.3.1 2018-02-13 16:55:18 -05:00
Taylor Yu f0ed7895ca fix make check-changes 2018-02-13 15:07:55 -06:00
David Goulet e7f6314782 Make check-changes happy 
Signed-off-by: David Goulet <dgoulet@torproject.org>
 2018-02-13 14:56:31 -05:00
David Goulet 9cf8d669fa man: Document default values if not in the consensus for DoS mitigation 
Fixes #25236

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2018-02-13 14:21:47 -05:00
David Goulet b60ffc5ce0 Merge remote-tracking branch 'dgoulet/bug25223_029_01' into ticket24902_029_05 2018-02-13 13:11:10 -05:00
David Goulet 305e39d0f8 dos: Add extra safety asserts in cc_stats_refill_bucket() 
Never allow the function to set a bucket value above the allowed circuit
burst.

Closes #25202

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2018-02-13 10:41:21 -05:00
David Goulet 4fe4f8179f dos: Don't set consensus param if we aren't a public relay 
We had this safeguard around dos_init() but not when the consensus changes
which can modify consensus parameters and possibly enable the DoS mitigation
even if tor wasn't a public relay.

Fixes #25223

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2018-02-13 10:35:41 -05:00
Nick Mathewson b9b7013062 Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-13 08:50:59 -05:00
Nick Mathewson 17a923941a Merge branch 'maint-0.2.9' into maint-0.3.1 2018-02-13 08:50:58 -05:00
David Goulet e658dad625 dirserv: Improve returned message when relay is rejected 
Explicitly inform the operator of the rejected relay to set a valid email
address in the ContactInfo field and contact bad-relays@ mailing list.

Fixes #25170

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2018-02-13 08:47:42 -05:00
Nick Mathewson 1555946e20 Have tor_addr hashes return a randomized hash for AF_UNSPEC. 
We don't expect this to come up very much, but we may as well make
sure that the value isn't predictable (as we do for the other
addresses) in case the issue ever comes up.

Spotted by teor.
 2018-02-12 11:14:36 -05:00
Nick Mathewson 99fbbc6c47 Fix a typo in an address_set.c comment. 2018-02-12 11:14:34 -05:00
Nick Mathewson 0f4b1020af Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-12 08:33:47 -05:00
Nick Mathewson 91109bc813 Merge branch 'maint-0.2.9' into maint-0.3.1 2018-02-12 08:33:47 -05:00
Nick Mathewson e91bae66d8 Merge branch 'bug23318-redux_029' into maint-0.2.9 2018-02-12 08:33:03 -05:00
Nick Mathewson 97c988c431 Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-11 18:11:04 -05:00
Nick Mathewson b2c4d4e7fa Merge branch 'maint-0.2.9' into maint-0.3.1 2018-02-11 18:11:04 -05:00
Nick Mathewson 84c13336c4 Merge remote-tracking branch 'public/bug24198_029' into maint-0.2.9 2018-02-11 18:10:59 -05:00
Nick Mathewson c93f69af58 Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-11 18:09:35 -05:00
Nick Mathewson 8939eaf479 Merge branch 'maint-0.2.9' into maint-0.3.1 2018-02-11 18:09:35 -05:00
Nick Mathewson 848ba26c18 Merge branch 'ticket24315_029' into maint-0.2.9 2018-02-11 18:07:37 -05:00
Nick Mathewson cf55f0516c Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-11 16:51:56 -05:00
Nick Mathewson eccef6ba60 Merge branch 'maint-0.2.9' into maint-0.3.1 2018-02-11 16:51:56 -05:00
Nick Mathewson 5dc785ceef Merge remote-tracking branch 'public/bug21074_029' into maint-0.2.9 2018-02-11 16:51:53 -05:00
Nick Mathewson ed13a7f625 Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-10 16:09:01 -05:00
Nick Mathewson 86583ad78e Merge branch 'maint-0.2.9' into maint-0.3.1 2018-02-10 16:09:00 -05:00
Nick Mathewson 320dac4602 Merge branch 'bug24978_029_enable' into maint-0.2.9 2018-02-10 16:08:58 -05:00
David Goulet 1a4fc9cddf test: DoS test to make sure we exclude known relays 
Part of #25193

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2018-02-09 11:31:01 -05:00
David Goulet 666582a679 dos: Exclude known relays from client connection count 
This is to avoid positively identifying Exit relays if tor client connection
comes from them that is reentering the network.

One thing to note is that this is done only in the DoS subsystem but we'll
still add it to the geoip cache as a "client" seen. This is done that way so
to avoid as much as possible changing the current behavior of the geoip client
cache since this is being backported.

Closes #25193

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2018-02-09 11:13:04 -05:00
David Goulet 112638921b Merge branch 'ticket25183_029_01' into ticket24902_029_05 2018-02-08 16:56:21 -05:00
David Goulet a445327b80 test: Add unit tests for addressset.c 
This also adds one that tests the integration with the nodelist.

Signed-off-by: David Goulet <dgoulet@torproject.org>
 2018-02-08 16:56:05 -05:00
Nick Mathewson 6892d32921 Add an address_set to the nodelist. 
This set is rebuilt whenever a consensus arrives.  In between
consensuses, it is add-only.
 2018-02-08 14:40:05 -05:00
Nick Mathewson 0640da4269 Function to add an ipv4 address to an address_set 
This is a convenience function, so callers don't need to wrap
the IPv4 address.
 2018-02-08 14:38:14 -05:00
Nick Mathewson 46bd2aed91 Add an address-set backend using a bloom filter. 
We're going to need this to make our anti-DoS code (see 24902) more
robust.
 2018-02-08 14:38:11 -05:00
Nick Mathewson abd6205384 Merge branch 'maint-0.3.1' into release-0.3.1 2018-02-08 10:29:06 -05:00