windows notifications: switch from desktoats to win_toats #350

dan · 2022-02-02T20:39:53Z

dan commented

2022-02-02 20:39:53 +00:00

No description provided.

dan added 1 commit 2022-02-02 20:39:53 +00:00

continuous-integration/drone/pr Build is passing Details

715b2c6876 windows notifications: switch from desktoats to win_toats

sarah reviewed 2022-02-02 20:43:41 +00:00

lib/notification_manager.dart Outdated

					
				@ -31,3 +32,3 @@

				  Future<void> notify(String message) async {

				    var iconPath = Uri.file(path.join(path.current, "cwtch.png"));

				    client.notify(message, appName: "cwtch", appIcon: iconPath.toString(), replacesId: this.previous_id).then((Notification value) => previous_id = value.id);

				    client

sarah commented

2022-02-02 20:41:52 +00:00

why formatting?

dan commented

2022-02-02 20:44:49 +00:00

my bad, i think my androidstudio on windows hasnt had line length set to 200

dan marked this conversation as resolved

lib/notification_manager.dart Outdated

					
				@ -38,4 +44,3 @@

				// windows notifications

				class WindowsNotificationManager implements NotificationsManager {

				  late ToastService service;

				  bool active = false;

sarah commented

2022-02-02 20:42:14 +00:00

why use active and not just Toast? ?

why use active and not just `Toast?` ?

dan commented

2022-02-02 20:46:58 +00:00

hm. make toast? a class level obj? i can try that

dan commented

2022-02-03 14:00:39 +00:00

so

         toast = await WinToast.instance().showToast(type: ToastType.text01, title: message);

is async so not too fast. when tested with with fuzzbot/blns it meant i'd see up to 6 active notifications get through. compared to just setting a bool at the top of the block, which with blns test maintained a solid 1 notification

so ``` toast = await WinToast.instance().showToast(type: ToastType.text01, title: message); ``` is async so not too fast. when tested with with fuzzbot/blns it meant i'd see up to 6 active notifications get through. compared to just setting a bool at the top of the block, which with blns test maintained a solid 1 notification

dan marked this conversation as resolved