we keep resharing profile pics even when the same #531

New Issue

dan · 2022-09-06T19:11:25Z

dan commented

2022-09-06 19:11:25 +00:00

this causes a slow build up of dups in download directories. now that we support longer lived shares we should reinvestigate how we share profile pics and now make a new share each time a profile turns on

sarah commented

2022-12-29 00:06:33 +00:00

Closing this, as I am pretty sure this doesn't happen - files are deduped by hash and a nonce provided by the sender, so assuming those are the same then multiple files shouldn't be downloaded unless they are actively shared.

We made a few fixes to file sharing in 1.10 that fixed some long-standing profile image bugs, but duplicate images was not among them.

Feel free to reopen if can reproduce bug.

Closing this, as I am pretty sure this doesn't happen - files are deduped by hash and a nonce provided by the sender, so assuming those are the same then multiple files shouldn't be downloaded unless they are actively shared. We made a few fixes to file sharing in 1.10 that fixed some long-standing profile image bugs, but duplicate images was not among them. Feel free to reopen if can reproduce bug.