cwtch.im
/
cwtch
16
20
Fork 15
Code Issues 10 Pull Requests 2 Releases 163 Wiki Activity

Support Save History Default + Delete Server #529

Merged
sarah merged 8 commits from stable-blockers into master 2023-08-22 20:22:23 +00:00
Conversation 3 Commits 8 Files Changed 8 +79 -19
sarah commented 2023-08-14 18:48:45 +00:00
Owner
Copy Link
No description provided.
dan was assigned by sarah 2023-08-14 18:48:46 +00:00
sarah added 1 commit 2023-08-14 18:48:46 +00:00
continuous-integration/drone/pr Build is passing Details
066ed86598 Support Save History Default + Delete Server
buildbot commented 2023-08-14 19:02:01 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/216

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/216
dan requested changes 2023-08-14 19:42:14 +00:00
event/common.go Outdated
@ -340,6 +341,7 @@ const (
DeleteHistoryDefault = "DefaultDeleteHistory"
SaveHistoryConfirmed = "SaveHistory"
DeleteHistoryConfirmed = "DeleteHistoryConfirmed"
SaveHistoryDefault = "DefaultSaveHistory"
dan commented 2023-08-14 19:38:35 +00:00
Owner
Copy Link

so we have a profile level default, and then conversation level override?

do we want to rename from xDefault to xProfile? and xConversation or something as it's now a two level thing? also the comment is wrong, we did have 3 states, now we have... well we might want 3, but different, like notifications: "default" (do profile setting), "save", "delete"

so we have a profile level default, and then conversation level override? do we want to rename from xDefault to xProfile? and xConversation or something as it's now a two level thing? also the comment is wrong, we did have 3 states, now we have... well we might want 3, but different, like notifications: "default" (do profile setting), "save", "delete"
dan commented 2023-08-14 19:43:18 +00:00
Owner
Copy Link

tho i guess we need to keep "DeleteHistoryDefault" for backwards compat too, but this should be split into two consts, and "DeleteHistoryDefault" now means just do the default, remeaning the name for compat

tho i guess we need to keep "DeleteHistoryDefault" for backwards compat too, but this should be split into two consts, and "DeleteHistoryDefault" now means just do the default, remeaning the name for compat
sarah commented 2023-08-14 19:54:08 +00:00
Author
Owner
Copy Link

Yeah, these need to stay the same for profile attribute/values compat. But their meanings are consistent.

Yeah, these need to stay the same for profile attribute/values compat. But their meanings are consistent.
functionality/servers/servers_functionality.go
@ -104,0 +108,4 @@
if err != nil {
return err
}
// Purge keys...
dan commented 2023-08-14 19:37:27 +00:00
Owner
Copy Link

what's the ui flow for this? will the UI warn / prompt about groups and delete them first if asked? do we have a way to signal a group is now serverless and will never be online?

what's the ui flow for this? will the UI warn / prompt about groups and delete them first if asked? do we have a way to signal a group is now serverless and will never be online?
sarah commented 2023-08-14 19:53:42 +00:00
Author
Owner
Copy Link

The main usecase for this right now is people cleaning up servers they no longer use. To that end we can just disable the button on the UI side if there are active groups.

The main usecase for this right now is people cleaning up servers they no longer use. To that end we can just disable the button on the UI side if there are active groups.
sarah added 1 commit 2023-08-14 20:18:58 +00:00
continuous-integration/drone/pr Build is pending Details
e1877d69b7 Better Comments on History Keys
sarah added 1 commit 2023-08-14 20:20:01 +00:00
continuous-integration/drone/pr Build is pending Details
aae8a7fc03 Spelling
dan approved these changes 2023-08-14 20:34:00 +00:00
sarah added 1 commit 2023-08-17 16:47:45 +00:00
sarah added 1 commit 2023-08-21 16:32:56 +00:00
sarah added 1 commit 2023-08-21 16:34:06 +00:00
continuous-integration/drone/pr Build is pending Details
5b2b839865 Update Dependencies
sarah added 1 commit 2023-08-21 17:26:55 +00:00
continuous-integration/drone/pr Build is pending Details
51f993973c Fixup Keys
sarah added 1 commit 2023-08-21 17:29:23 +00:00
continuous-integration/drone/pr Build is passing Details
d5c3795f13 Remove Unneeded Field
buildbot commented 2023-08-21 18:02:36 +00:00
Member
Copy Link

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/223

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/223
buildbot commented 2023-08-21 21:49:39 +00:00
Member
Copy Link

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/224

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/224
dan approved these changes 2023-08-22 20:22:11 +00:00
sarah merged commit 95527f8978 into master 2023-08-22 20:22:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
applications

   
BLOCKED

   
bug

   
design

   
duplicate

   
enhancement

   
fixed?

   
funding-needed

   
help wanted

   
infrastructure

   
invalid

   
payments

   
qubes

   
question

   
ready-for-implementation

   
refactor

   
spam

   
tapir-server

   
testing

   
tor

   
wontfix
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
dan
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cwtch.im/cwtch#529
No description provided.
Delete Branch "stable-blockers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?