Support Save History Default + Delete Server #529
No reviewers
Labels
No Label
applications
BLOCKED
bug
design
duplicate
enhancement
fixed?
funding-needed
help wanted
infrastructure
invalid
payments
qubes
question
ready-for-implementation
refactor
spam
tapir-server
testing
tor
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cwtch.im/cwtch#529
Loading…
Reference in New Issue
No description provided.
Delete Branch "stable-blockers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/216
@ -340,6 +341,7 @@ const (
DeleteHistoryDefault = "DefaultDeleteHistory"
SaveHistoryConfirmed = "SaveHistory"
DeleteHistoryConfirmed = "DeleteHistoryConfirmed"
SaveHistoryDefault = "DefaultSaveHistory"
so we have a profile level default, and then conversation level override?
do we want to rename from xDefault to xProfile? and xConversation or something as it's now a two level thing? also the comment is wrong, we did have 3 states, now we have... well we might want 3, but different, like notifications: "default" (do profile setting), "save", "delete"
tho i guess we need to keep "DeleteHistoryDefault" for backwards compat too, but this should be split into two consts, and "DeleteHistoryDefault" now means just do the default, remeaning the name for compat
Yeah, these need to stay the same for profile attribute/values compat. But their meanings are consistent.
@ -104,0 +108,4 @@
if err != nil {
return err
}
// Purge keys...
what's the ui flow for this? will the UI warn / prompt about groups and delete them first if asked? do we have a way to signal a group is now serverless and will never be online?
The main usecase for this right now is people cleaning up servers they no longer use. To that end we can just disable the button on the UI side if there are active groups.
Drone Build Status: failure
https://build.openprivacy.ca/cwtch.im/cwtch/223
Drone Build Status: success
https://build.openprivacy.ca/cwtch.im/cwtch/224