#163 merging some bugfixes

Merged
sarah merged 1 commits from bigmerge into master 1 year ago
erinn commented 1 year ago

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out
buildbot commented 1 year ago
Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278
buildbot commented 1 year ago
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280
sarah closed this pull request 1 year ago
dan commented 1 year ago
Owner

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork
dan commented 1 year ago
Owner

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already
The pull request has been merged as ddbf96e668.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.