merging some bugfixes #163

Fusionnée

sarah a fusionné 1 révision(s) à partir de bigmerge vers master

2018-11-22 01:05:24 +00:00

erinn a commenté

2018-11-22 00:48:41 +00:00

.

Propriétaire

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot a commenté

2018-11-22 00:49:00 +00:00

.

Membre

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot a commenté

2018-11-22 01:03:26 +00:00

.

Membre

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah a fermé cette demande d'ajout

2018-11-22 01:05:23 +00:00

.

dan a commenté

2018-11-22 05:43:33 +00:00

.

Propriétaire

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan a commenté

2018-11-22 06:52:22 +00:00

.

Propriétaire

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

Connectez-vous pour rejoindre cette conversation.

Sans évaluateur

Sans labels

ready-for-implementation

Sans jalon

Sans assignation

3 participants

Notifications

Échéance

La date d’échéance est invalide ou hors plage. Veuillez utiliser le format 'aaaa-mm-dd'.

Aucune échéance n'a été définie.

Dépendances

Aucune dépendance définie.

Référence : cwtch.im/cwtch#163

Sans contenu.