merging some bugfixes #163

Sapludināts

sarah sapludināja 1 revīzijas no bigmerge uz master

2018-11-22 01:05:24 +00:00

erinn komentēja

2018-11-22 00:48:41 +00:00

Īpašnieks

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot komentēja

2018-11-22 00:49:00 +00:00

Biedri

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot komentēja

2018-11-22 01:03:26 +00:00

Biedri

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah aizvēra šo izmaiņu pieprasījumu

2018-11-22 01:05:23 +00:00

dan komentēja

2018-11-22 05:43:33 +00:00

Īpašnieks

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan komentēja

2018-11-22 06:52:22 +00:00

Īpašnieks

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

Pierakstieties, lai pievienotos šai sarunai.

Nav recenzentu

Nav etiķešu

ready-for-implementation

Nav atskaites punktu

Nav atbildīgo

3 dalībnieki

Paziņojumi

Izpildes termiņš

Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Atsaucas uz: cwtch.im/cwtch#163

No description provided.