merging some bugfixes #163

Scalone

sarah scala 1 commity/ów z bigmerge do master

2018-11-22 01:05:24 +00:00

erinn skomentował(-a)

2018-11-22 00:48:41 +00:00

Właściciel

we need to be able to set the AIF before launching individual peers, so this splits that out

we need to be able to set the AIF before launching individual peers, so this splits that out

buildbot skomentował(-a)

2018-11-22 00:49:00 +00:00

Członek

Drone Build Status: failure

https://build.openprivacy.ca/cwtch.im/cwtch/278

Drone Build Status: failure https://build.openprivacy.ca/cwtch.im/cwtch/278

buildbot skomentował(-a)

2018-11-22 01:03:26 +00:00

Członek

Drone Build Status: success

https://build.openprivacy.ca/cwtch.im/cwtch/280

Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/280

sarah zamknął(-ęła) ten pull request

2018-11-22 01:05:23 +00:00

dan skomentował(-a)

2018-11-22 05:43:33 +00:00

Właściciel

i did away with startPeer in app
Listen now does the go function thing, so you can call peer.Listen directly and itll fork

i did away with startPeer in app Listen now does the go function thing, so you can call peer.Listen directly and itll fork

dan skomentował(-a)

2018-11-22 06:52:22 +00:00

Właściciel

so yeah
lines 113-114

 		p.Init(app.mn)
 		p.Listen()

start and launch the peer. I got rid of app.startPeer cus its wrong and terrible

to be fair, LaunchPeers will basically nop
because
.Listen go calls .listenFn inside a look to handle socket fails
and you added cp.started = true inside listenFn
so LaunchPeers should always find them all started already

so yeah lines 113-114 ``` p.Init(app.mn) p.Listen() ``` start and launch the peer. I got rid of app.startPeer cus its wrong and terrible to be fair, LaunchPeers will basically nop because .Listen go calls .listenFn inside a look to handle socket fails and you added `cp.started = true` inside listenFn so LaunchPeers should always find them all `started` already

Zaloguj się, aby dołączyć do tej rozmowy.

Brak recenzentów

Brak etykiety

ready-for-implementation

Brak kamienia milowego

Brak przypisanych

Uczestnicy 3

Powiadomienia

Termin realizacji

Data realizacji jest niewłaściwa lub spoza zakresu. Użyj formatu 'yyyy-mm-dd'.

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Reference: cwtch.im/cwtch#163

No description provided.