#176 BUGFIX: Sorting Function

Merged
dan merged 1 commits from sorting into master 1 year ago
sarah commented 1 year ago

Sorting is inaccurate if we don’t short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI).

This also adds an explicit sorting function that should probably never be called (it’s effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I’d rather not focus on building out that functionality right now.

Sorting is inaccurate if we don't short circuit on Before (I mistakenly removed this check to fix p2p timelines and it created weird sorting rules in group timelines in the UI). This also adds an explicit sorting function that should probably never be called (it's effectively a noop in the average case) except in cases where sorting rules change and we have prior saved messages. There are probably much better ways to do this (i.e. when we load from a profile, go through and sort everything) - but I'd rather not focus on building out that functionality right now.
buildbot commented 1 year ago
Drone Build Status: success https://build.openprivacy.ca/cwtch.im/cwtch/317
dan commented 1 year ago
Owner

its a slow noop tho as it still does a full order check on the entire timeline? yeah I hope we dont need call it

its a slow noop tho as it still does a full order check on the entire timeline? yeah I hope we dont need call it
The pull request has been merged.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.